From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758168AbcH3QmB (ORCPT ); Tue, 30 Aug 2016 12:42:01 -0400 Received: from lan.nucleusys.com ([92.247.61.126]:40600 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753657AbcH3Ql6 (ORCPT ); Tue, 30 Aug 2016 12:41:58 -0400 Date: Tue, 30 Aug 2016 19:41:48 +0300 From: Petko Manolov To: Bhaktipriya Shridhar Cc: Petko Manolov , Tejun Heo , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: pegasus: Remove deprecated create_singlethread_workqueue Message-ID: <20160830164148.fz4tbei5g7dlma4n@p310> References: <20160830163247.GA25925@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160830163247.GA25925@Karyakshetra> User-Agent: Mutt/1.6.2-neo (2016-07-23) X-Spam-Score: -1.0 (-) X-Spam-Report: Spam detection software, running on the system "zztop.nucleusys.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 16-08-30 22:02:47, Bhaktipriya Shridhar wrote: > The workqueue "pegasus_workqueue" queues a single work item per pegasus > instance and hence it doesn't require execution ordering. Hence, > alloc_workqueue has been used to replace the deprecated > create_singlethread_workqueue instance. > > The WQ_MEM_RECLAIM flag has been set to ensure forward progress under > memory pressure since it's a network driver. > > Since there are fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/net/usb/pegasus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c > index 9bbe0161..1434e5d 100644 > --- a/drivers/net/usb/pegasus.c > +++ b/drivers/net/usb/pegasus.c > @@ -1129,7 +1129,8 @@ static int pegasus_probe(struct usb_interface *intf, > return -ENODEV; > > if (pegasus_count == 0) { > - pegasus_workqueue = create_singlethread_workqueue("pegasus"); > + pegasus_workqueue = alloc_workqueue("pegasus", WQ_MEM_RECLAIM, > + 0); > if (!pegasus_workqueue) > return -ENOMEM; > } > -- > 2.1.4 [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-08-30 22:02:47, Bhaktipriya Shridhar wrote: > The workqueue "pegasus_workqueue" queues a single work item per pegasus > instance and hence it doesn't require execution ordering. Hence, > alloc_workqueue has been used to replace the deprecated > create_singlethread_workqueue instance. > > The WQ_MEM_RECLAIM flag has been set to ensure forward progress under > memory pressure since it's a network driver. > > Since there are fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/net/usb/pegasus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c > index 9bbe0161..1434e5d 100644 > --- a/drivers/net/usb/pegasus.c > +++ b/drivers/net/usb/pegasus.c > @@ -1129,7 +1129,8 @@ static int pegasus_probe(struct usb_interface *intf, > return -ENODEV; > > if (pegasus_count == 0) { > - pegasus_workqueue = create_singlethread_workqueue("pegasus"); > + pegasus_workqueue = alloc_workqueue("pegasus", WQ_MEM_RECLAIM, > + 0); > if (!pegasus_workqueue) > return -ENOMEM; > } > -- > 2.1.4 Nope, there is no need for singlethread-ness here. As long as the flag you used is doing the right thing i am OK with the patch. Petko