From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758444AbcH3Q4X (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 12:56:23 -0400
Received: from mga11.intel.com ([192.55.52.93]:39019 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758212AbcH3Q4V (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 12:56:21 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,257,1470726000"; 
   d="scan'208";a="1022355342"
Date: Tue, 30 Aug 2016 22:34:22 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
        jcm@redhat.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Dan Williams <dan.j.williams@intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Dave Jiang <dave.jiang@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for
 tx_status
Message-ID: <20160830170422.GN9355@localhost>
References: <1471927691-28827-1-git-send-email-okaya@codeaurora.org>
 <1471927691-28827-4-git-send-email-okaya@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1471927691-28827-4-git-send-email-okaya@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote:

>  	spin_lock_init(&lldev->lock);
> -	tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev);

??

This is not described in changlog? If you are not using in anywhere else,
then rst_task variable should be removed too..

-- 
~Vinod