From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758525AbcH3RLw (ORCPT ); Tue, 30 Aug 2016 13:11:52 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:33940 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755250AbcH3RLt (ORCPT ); Tue, 30 Aug 2016 13:11:49 -0400 Date: Tue, 30 Aug 2016 12:11:46 -0500 From: Rob Herring To: Chanwoo Choi Cc: k.kozlowski@samsung.com, kgene@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, jh80.chung@samsung.com, sw0312.kim@samsung.com, jy0922.shim@samsung.com, inki.dae@samsung.com, jonghwa3.lee@samsung.com, beomho.seo@samsung.com, jaewon02.kim@samsung.com, human.hwang@samsung.com, ideal.song@samsung.com, ingi2.kim@samsung.com, m.szyprowski@samsung.com, a.hajda@samsung.com, s.nawrocki@samsung.com, chanwoo@kernel.org Subject: Re: [PATCH v2 6/7] arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board Message-ID: <20160830171146.GA22946@rob-hp-laptop> References: <1472046551-703-1-git-send-email-cw00.choi@samsung.com> <1472046551-703-7-git-send-email-cw00.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472046551-703-7-git-send-email-cw00.choi@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 10:49:10PM +0900, Chanwoo Choi wrote: > This patch adds the Device Tree source for Exynos5433-based Samsung TM2 board. > This board fully support the all things for mobile target. > > This patch supports the following devices: > 1. basic SoC > - Initial booting for Samsung Exynos5433 SoC > - DRAM LPDDR3 (3GB) > - eMMC (32GB) > - ARM architecture timer > > 2. power management devices > - Sasmung S2MPS13 PMIC for the power supply > - CPUFREQ for big.LITTLE cores > - TMU for big.LITTLE cores and GPU > - ADC with thermistor to measure the temperature of AP/Battery/Charger > - Maxim MAX77843 Interface PMIC (MUIC/Haptic/Regulator) > > 3. sound devices > - I2S for sound bus > - LPASS for sound power control > - Wolfson WM5110 for sound codec > - Maxim MAX98504 for speaker amplifier > - TM2 ASoC Machine device driver node > > 3. display devices > - DECON, DSI and MIC for the panel output > > 4. usb devices > - USB 3.0 DRD (Dual Role Device) > - USB 3.0 Host controller > > 5. storage devices > - MSHC (Mobile Storae Host Controller) for eMMC device > > 6. misc devices > - gpio-keys (power, volume up/down, home key) > - PWM (Pulse Width Modulation Timer) > > Signed-off-by: Chanwoo Choi > Signed-off-by: Jaehoon Chung > Signed-off-by: Seung-Woo Kim > Signed-off-by: Joonyoung Shim > Signed-off-by: Inki Dae > Signed-off-by: Jonghwa Lee > Signed-off-by: Beomho Seo > Signed-off-by: Jaewon Kim > Signed-off-by: Hyungwon Hwang > Signed-off-by: Inha Song > Signed-off-by: Ingi kim > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Marek Szyprowski > Signed-off-by: Andrzej Hajda > Signed-off-by: Sylwester Nawrocki > --- > .../bindings/arm/samsung/samsung-boards.txt | 1 + > arch/arm64/boot/dts/exynos/Makefile | 5 +- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 985 +++++++++++++++++++++ > 3 files changed, 990 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > > diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt > index 0ea7f14ef294..c704b4bf6137 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt > @@ -15,6 +15,7 @@ Required root node properties: > - "samsung,xyref5260" - for Exynos5260-based Samsung board. > - "samsung,smdk5410" - for Exynos5410-based Samsung SMDK5410 eval board. > - "samsung,smdk5420" - for Exynos5420-based Samsung SMDK5420 eval board. > + - "samsung,tm2" - for Exynos5333-based Samsung TM2 board. This does not match... > + compatible = "samsung,exynos5433-tm2", "samsung,exynos5433"; Is it 5433 or 5333? > + > + aliases { > + pinctrl0 = &pinctrl_alive; > + pinctrl1 = &pinctrl_aud; > + pinctrl2 = &pinctrl_cpif; > + pinctrl3 = &pinctrl_ese; > + pinctrl4 = &pinctrl_finger; > + pinctrl5 = &pinctrl_fsys; > + pinctrl6 = &pinctrl_imem; > + pinctrl7 = &pinctrl_nfc; > + pinctrl8 = &pinctrl_peric; > + pinctrl9 = &pinctrl_touch; Drop all these. > + serial0 = &serial_0; > + serial1 = &serial_1; > + serial2 = &serial_2; > + serial3 = &serial_3; > + spi0 = &spi_0; > + spi1 = &spi_1; > + spi2 = &spi_2; > + spi3 = &spi_3; > + spi4 = &spi_4; And these.