From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758555AbcH3VPj (ORCPT ); Tue, 30 Aug 2016 17:15:39 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:36148 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758348AbcH3VPf (ORCPT ); Tue, 30 Aug 2016 17:15:35 -0400 Date: Tue, 30 Aug 2016 16:15:32 -0500 From: Andy Gross To: "Gupta, Puja" Cc: Stanimir Varbanov , Ohad Ben-Cohen , Bjorn Andersson , Stephen Boyd , Rob Herring , Mark Rutland , Rob Clark , Srinivas Kandagatla , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] firmware: qcom: scm: add iommu scm calls for pg table Message-ID: <20160830211532.GE24683@hector.attlocal.net> References: <1471622000-1906-1-git-send-email-stanimir.varbanov@linaro.org> <1471622000-1906-3-git-send-email-stanimir.varbanov@linaro.org> <14e4872a-7775-4221-140a-e08d28ae9098@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14e4872a-7775-4221-140a-e08d28ae9098@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 11:35:29AM -0700, Gupta, Puja wrote: > On 8/19/2016 8:53 AM, Stanimir Varbanov wrote: > >Those two scm calls are used to get the size of secure iommu > >page table and to pass physical memory address for this page > >table. The calls are used by remoteproc venus driver to load > >the firmware. > Do we really need these additional scm calls for venus? why can't we just > reuse existing __qcom_scm_pas_mem_setup() call? Keep in mind this is with the smmu-v1 on 8916. It seems like the downstream kernel has to do extra stuff when dealing with the older smmu. The newer platforms handle this quasi-transparently. Regards, Andy