From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbcHaEH5 (ORCPT ); Wed, 31 Aug 2016 00:07:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbcHaEH4 (ORCPT ); Wed, 31 Aug 2016 00:07:56 -0400 Date: Wed, 31 Aug 2016 06:07:51 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Suravee Suthikulpanit Cc: joro@8bytes.org, pbonzini@redhat.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sherry.hurwitz@amd.com Subject: Re: [PART2 PATCH v7 12/12] svm: Implements update_pi_irte hook to setup posted interrupt Message-ID: <20160831040751.GA31840@potion> References: <1471978363-13756-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1471978363-13756-13-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1471978363-13756-13-git-send-email-Suravee.Suthikulpanit@amd.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 31 Aug 2016 04:07:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-08-23 13:52-0500, Suravee Suthikulpanit: > From: Suravee Suthikulpanit > > This patch implements update_pi_irte function hook to allow SVM > communicate to IOMMU driver regarding how to set up IRTE for handling > posted interrupt. > > In case AVIC is enabled, during vcpu_load/unload, SVM needs to update > IOMMU IRTE with appropriate host physical APIC ID. Also, when > vcpu_blocking/unblocking, SVM needs to update the is-running bit in > the IOMMU IRTE. Both are achieved via calling amd_iommu_update_ga(). > > However, if GA mode is not enabled for the pass-through device, > IOMMU driver will simply just return when calling amd_iommu_update_ga. > > Signed-off-by: Suravee Suthikulpanit > --- I forgot nitpicks in the office before going on a vacation, ;) Reviewed-by: Radim Krčmář