From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758635AbcHaG7A (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 Aug 2016 02:59:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36770 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755713AbcHaG67 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 Aug 2016 02:58:59 -0400
Date: Wed, 31 Aug 2016 08:58:56 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        jolsa@kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V6 1/5] perf tools: making coresight PMU listable
Message-ID: <20160831065856.GA4740@krava>
References: <1472156445-24283-1-git-send-email-mathieu.poirier@linaro.org>
 <1472156445-24283-2-git-send-email-mathieu.poirier@linaro.org>
 <20160828141611.GA32293@krava>
 <CANLsYky4TY5s46nVTra+7-Zx+czjWZbmmJgqHenLTRNd1TM=CQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANLsYky4TY5s46nVTra+7-Zx+czjWZbmmJgqHenLTRNd1TM=CQ@mail.gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 31 Aug 2016 06:58:58 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 29, 2016 at 09:56:02AM -0600, Mathieu Poirier wrote:
> On 28 August 2016 at 08:16, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Thu, Aug 25, 2016 at 02:20:41PM -0600, Mathieu Poirier wrote:
> >
> > SNIP
> >
> >>  ARM/CORGI MACHINE SUPPORT
> >>  M:   Richard Purdie <rpurdie@rpsys.net>
> >> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> >> index 24803c58049a..72edf83d76b7 100644
> >> --- a/tools/perf/Makefile.config
> >> +++ b/tools/perf/Makefile.config
> >> @@ -746,10 +746,13 @@ ifdef LIBBABELTRACE
> >>  endif
> >>
> >>  ifndef NO_AUXTRACE
> >> -  ifeq ($(feature-get_cpuid), 0)
> >> -    msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> >> -    NO_AUXTRACE := 1
> >> -  else
> >> +  ifeq ($(ARCH),x86)
> >> +    ifeq ($(feature-get_cpuid), 0)
> >> +      msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> >> +      NO_AUXTRACE := 1
> >> +    endif
> >> +  endif
> >> +  ifndef NO_AUXTRACE
> >
> > hum, how's this hunk connected to the issue described in changelog?
> 
> Patch 1/6 and 2/6 are needed by [3, 4, 5, 6]/6 of this set.
> Originally they were part of a separate patchset I but decided to
> include them here for completeness.  Let me know if you'd like to see
> them split again.

ook, jirka