From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964960AbcHaPj1 (ORCPT ); Wed, 31 Aug 2016 11:39:27 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33225 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934324AbcHaPjU (ORCPT ); Wed, 31 Aug 2016 11:39:20 -0400 Date: Wed, 31 Aug 2016 08:39:29 -0700 From: Stephen Hemminger To: Julia Lawall Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] constify ethtool_ops structures Message-ID: <20160831083929.62832cea@xeon-e3> In-Reply-To: <1472628648-3603-1-git-send-email-Julia.Lawall@lip6.fr> References: <1472628648-3603-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 Aug 2016 09:30:42 +0200 Julia Lawall wrote: > Constify ethtool_ops structures. > > --- > > drivers/net/ethernet/agere/et131x.c | 2 +- > drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- > drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +- > drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +- > drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 2 +- > drivers/net/ethernet/synopsys/dwc_eth_qos.c | 2 +- > drivers/staging/slicoss/slicoss.c | 4 ++-- > 9 files changed, 10 insertions(+), 10 deletions(-) > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Other drivers with same type of issue drivers/net/ethernet/mediatek/mtk_eth_soc.c:static struct ethtool_ops mtk_ethtool_ops = { drivers/net/ethernet/synopsys/dwc_eth_qos.c:static struct ethtool_ops dwceqos_ethtool_ops = { drivers/net/ethernet/xilinx/xilinx_axienet_main.c:static struct ethtool_ops axienet_ethtool_ops = { drivers/net/usb/r8152.c:static struct ethtool_ops ops = { drivers/staging/netlogic/xlr_net.c:static struct ethtool_ops xlr_ethtool_ops = {