Re: [PATCH 0/6] constify ethtool_ops structures

Julia Lawall
2016-08-31T19:40:41Z

On Wed, 31 Aug 2016, Stephen Hemminger wrote:

> On Wed, 31 Aug 2016 09:30:42 +0200
> Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> > Constify ethtool_ops structures.
> >
> > ---
> >
> > drivers/net/ethernet/agere/et131x.c | 2 +-
> > drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
> > drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
> > drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +-
> > drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +-
> > drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +-
> > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 2 +-
> > drivers/net/ethernet/synopsys/dwc_eth_qos.c | 2 +-
> > drivers/staging/slicoss/slicoss.c | 4 ++--
> > 9 files changed, 10 insertions(+), 10 deletions(-)
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
> Other drivers with same type of issue
>
>
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:static struct ethtool_ops mtk_ethtool_ops = {
> drivers/net/ethernet/synopsys/dwc_eth_qos.c:static struct ethtool_ops dwceqos_ethtool_ops = {
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:static struct ethtool_ops axienet_ethtool_ops = {
> drivers/net/usb/r8152.c:static struct ethtool_ops ops = {
> drivers/staging/netlogic/xlr_net.c:static struct ethtool_ops xlr_ethtool_ops = {

Thanks. Probably they don't compile for x86, or at least not with make
allyesconfig. I can check on them.

julia