From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759222AbcHaL0v (ORCPT ); Wed, 31 Aug 2016 07:26:51 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35296 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbcHaL0r (ORCPT ); Wed, 31 Aug 2016 07:26:47 -0400 Date: Wed, 31 Aug 2016 12:28:19 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, patrice.chotard@st.com, dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com, ohad@wizery.com, bjorn.andersson@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-remoteproc@vger.kernel.org, Arnaud Pouliquen Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Message-ID: <20160831112819.GJ27357@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> <20160830100148.GO1661@dell> <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160830142112.GA22514@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2016, Peter Griffin wrote: > Thanks for reviewing and your very valuable feedback. > On Tue, 30 Aug 2016, Lee Jones wrote: > > On Fri, 26 Aug 2016, Peter Griffin wrote: > > > > > This patch adds the DT node for the uniperif reader > > > IP block found on STiH407 family silicon. > > > > > > Signed-off-by: Arnaud Pouliquen > > > Signed-off-by: Peter Griffin > > > --- > > > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > > > index d263c96..bdddf2c 100644 > > > --- a/arch/arm/boot/dts/stih407-family.dtsi > > > +++ b/arch/arm/boot/dts/stih407-family.dtsi > > > @@ -956,5 +956,31 @@ > > > st,version = <5>; > > > st,mode = "SPDIF"; > > > }; > > > + > > > + sti_uni_reader0: sti-uni-reader@0 { > > > + compatible = "st,sti-uni-reader"; > > > + status = "disabled"; > > > > I find it's normally nicer to place the status of the node at the > > bottom, separated by a '\n'. > > Ok I'll add a superflous '\n' in the next version. Everyone loves a smart arse! In this case I believe the '\n' to be a functional separator and not superfluous at all. > > > + dai-name = "Uni Reader #0 (PCM IN)"; > > > > Oooo, not seen something like this before. > > > > If it does not already have one, it would require a DT Ack. > > No idea, the driver got merged 1 year ago. > > Arnaud did you get a DT ack when you merged this driver & binding? > > > > > + st,version = <3>; > > > > This will likely need a DT Ack too. We usually encode this sort of > > information in the compatible string. > > See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c Well Rob's the boss. We certainly never used to take 'device ID' or 'version' attributes. I guess something must have changed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog