From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933746AbcHaLng (ORCPT ); Wed, 31 Aug 2016 07:43:36 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36916 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933027AbcHaLnb (ORCPT ); Wed, 31 Aug 2016 07:43:31 -0400 Date: Wed, 31 Aug 2016 12:45:17 +0100 From: Lee Jones To: Nicolas Boichat Cc: gwendal@chromium.org, ejcaruso@chromium.org, Olof Johansson , linux-kernel@vger.kernel.org, groeck@chromium.org Subject: Re: [PATCH 1/3] mfd: cros_ec: Add EC console read structures definitions Message-ID: <20160831114517.GC8649@dell> References: <1471926859-21263-1-git-send-email-drinkcat@chromium.org> <1471926859-21263-2-git-send-email-drinkcat@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1471926859-21263-2-git-send-email-drinkcat@chromium.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Aug 2016, Nicolas Boichat wrote: > ec_params_console_read_v1 is used to capture EC logs from kernel, > and ec_params_get_cmd_versions_v1 is used to probe whether EC > supports that command. > > Signed-off-by: Nicolas Boichat > --- > include/linux/mfd/cros_ec_commands.h | 21 ++++++++++++++++++++- Acked-by: Lee Jones I guess this will be taken through Olof's tree? > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h > index 7e7a8d4..74c84e82 100644 > --- a/include/linux/mfd/cros_ec_commands.h > +++ b/include/linux/mfd/cros_ec_commands.h > @@ -625,6 +625,10 @@ struct ec_params_get_cmd_versions { > uint8_t cmd; /* Command to check */ > } __packed; > > +struct ec_params_get_cmd_versions_v1 { > + uint16_t cmd; /* Command to check */ > +} __packed; > + > struct ec_response_get_cmd_versions { > /* > * Mask of supported versions; use EC_VER_MASK() to compare with a > @@ -2003,13 +2007,28 @@ struct ec_params_charge_control { > #define EC_CMD_CONSOLE_SNAPSHOT 0x97 > > /* > - * Read next chunk of data from saved snapshot. > + * Read data from the saved snapshot. If the subcmd parameter is > + * CONSOLE_READ_NEXT, this will return data starting from the beginning of > + * the latest snapshot. If it is CONSOLE_READ_RECENT, it will start from the > + * end of the previous snapshot. > + * > + * The params are only looked at in version >= 1 of this command. Prior > + * versions will just default to CONSOLE_READ_NEXT behavior. > * > * Response is null-terminated string. Empty string, if there is no more > * remaining output. > */ > #define EC_CMD_CONSOLE_READ 0x98 > > +enum ec_console_read_subcmd { > + CONSOLE_READ_NEXT = 0, > + CONSOLE_READ_RECENT > +}; > + > +struct ec_params_console_read_v1 { > + uint8_t subcmd; /* enum ec_console_read_subcmd */ > +} __packed; > + > /*****************************************************************************/ > > /* -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog