From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935217AbcHaObO (ORCPT ); Wed, 31 Aug 2016 10:31:14 -0400 Received: from mail-yb0-f193.google.com ([209.85.213.193]:33504 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933835AbcHaObN (ORCPT ); Wed, 31 Aug 2016 10:31:13 -0400 Date: Wed, 31 Aug 2016 10:31:10 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Martin Schwidefsky , Heiko Carstens , Steffen Maier , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue Message-ID: <20160831143110.GT12660@htj.duckdns.org> References: <20160830202720.GA31494@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160830202720.GA31494@Karyakshetra> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 01:57:20AM +0530, Bhaktipriya Shridhar wrote: > The workqueue "appldata_wq" has been replaced with an ordered dedicated > workqueue. > > WQ_MEM_RECLAIM has not been set since the workqueue is not being used on > a memory reclaim path. > > The adapter->work_queue queues multiple work items viz > &adapter->scan_work, &port->rport_work, &adapter->ns_up_work, > &adapter->stat_work, adapter->work_queue, &adapter->events.work, > &port->gid_pn_work, &port->test_link_work. Hence, an ordered > dedicated workqueue has been used. > > WQ_MEM_RECLAIM has been set to ensure forward progress under memory > pressure. I have no idea what these drivers do. s390 folks, can you please shed some light on whether these workqueues can be depended on during memory reclaim? Thanks. -- tejun