From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964861AbcHaOmt (ORCPT ); Wed, 31 Aug 2016 10:42:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:56552 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934320AbcHaOms (ORCPT ); Wed, 31 Aug 2016 10:42:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,262,1470726000"; d="scan'208";a="162893941" Date: Wed, 31 Aug 2016 07:42:47 -0700 From: Andi Kleen To: Jiri Olsa Cc: Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , peterz@infradead.org, maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v20 00/20] perf, tools: Add support for PMU events in JSON format Message-ID: <20160831144247.GV3078@tassilo.jf.intel.com> References: <1466481770-25290-1-git-send-email-sukadev@linux.vnet.ibm.com> <20160831114254.GA9001@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160831114254.GA9001@krava> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > hi, > I had discussion with Ingo about the state of this patchset > and there's one more requirement from his side - to split > event files into per topic files Thanks Jiri. > > I made some initial changes over latest Sukadev's branch > and came up with something like this: Did you just split it by the "Topic" fields? > > $ find pmu-events/arch/x86/ > pmu-events/arch/x86/ > pmu-events/arch/x86/NehalemEX_core > pmu-events/arch/x86/NehalemEX_core/Memory.json > pmu-events/arch/x86/NehalemEX_core/Virtual-Memory.json > pmu-events/arch/x86/NehalemEX_core/Cache.json > pmu-events/arch/x86/NehalemEX_core/Pipeline.json > pmu-events/arch/x86/NehalemEX_core/Floating-point.json > pmu-events/arch/x86/NehalemEX_core/Other.json > pmu-events/arch/x86/mapfile.csv > pmu-events/arch/x86/Broadwell_core > pmu-events/arch/x86/Broadwell_core/Memory.json > pmu-events/arch/x86/Broadwell_core/Virtual-Memory.json > pmu-events/arch/x86/Broadwell_core/Cache.json > pmu-events/arch/x86/Broadwell_core/Pipeline.json > pmu-events/arch/x86/Broadwell_core/Floating-point.json > pmu-events/arch/x86/Broadwell_core/Other.json > pmu-events/arch/x86/Broadwell_core/Frontend.json > > so let's have a discussion if this is acceptable for you guys Splitting is fine for me, as long as it's scriptable. I already have some scripts to generate the perf json files, can update them to split. > > I've already made some changes in pmu-events/* to support > this hierarchy to see how bad the change would be.. and > it's not that bad ;-) Everything has to be automated, please no manual changes. -Andi