From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935277AbcHaOnS (ORCPT ); Wed, 31 Aug 2016 10:43:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40543 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933835AbcHaOnR (ORCPT ); Wed, 31 Aug 2016 10:43:17 -0400 Date: Wed, 31 Aug 2016 16:43:26 +0200 From: Greg KH To: Mario_Limonciello@Dell.com Cc: Allen_Hung@Dell.com, jdelvare@suse.com, rmk+kernel@arm.linux.org.uk, somlo@cmu.edu, bjorn.andersson@sonymobile.com, jens.wiklander@linaro.org, agross@codeaurora.org, arnd@arndb.de, sudeep.holla@arm.com, eric@anholt.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] dmi-id: add dmi/id/oem group for exporting oem strings to sysfs Message-ID: <20160831144326.GA24945@kroah.com> References: <1471252925-8082-1-git-send-email-allen_hung@dell.com> <20160831124002.GA26534@kroah.com> <488533a5959a46eca5f037cca26f42bd@ausx13mpc124.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <488533a5959a46eca5f037cca26f42bd@ausx13mpc124.AMER.DELL.COM> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2016 at 02:01:23PM +0000, Mario_Limonciello@Dell.com wrote: > Hi Greg, > > > -----Original Message----- > > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > > Sent: Wednesday, August 31, 2016 7:40 AM > > To: Hung, Allen > > Cc: Jean Delvare ; Russell King > > ; Gabriel Somlo ; Bjorn > > Andersson ; Jens Wiklander > > ; Andy Gross ; Arnd > > Bergmann ; Sudeep Holla ; Eric > > Anholt ; linux-kernel@vger.kernel.org; Limonciello, Mario > > > > Subject: Re: [PATCH v3 2/2] dmi-id: add dmi/id/oem group for exporting oem > > strings to sysfs > > > > On Mon, Aug 15, 2016 at 05:22:05PM +0800, Allen Hung wrote: > > > The oem strings in DMI system identification information of the BIOS > > > have been parsed and stored as dmi devices in dmi_scan.c but they are > > > not exported to userspace via sysfs. > > > > > > The patch intends to export oem strings to sysfs device /sys/class/dmi/id. > > > As the number of oem strings are dynamic, a group "oem" is added to > > > the device and the strings will be added to the group as string1, > > > string2, ..., and stringN. > > > > > > Signed-off-by: Allen Hung > > > --- > > > drivers/firmware/Kconfig | 9 ++++ > > > drivers/firmware/dmi-id.c | 116 > > > ++++++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 125 insertions(+) > > > > > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index > > > 6664f11..885a6c9 100644 > > > --- a/drivers/firmware/Kconfig > > > +++ b/drivers/firmware/Kconfig > > > @@ -119,6 +119,15 @@ config DMIID > > > information from userspace through /sys/class/dmi/id/ or if you want > > > DMI-based module auto-loading. > > > > > > +config DMIID_OEM_STRINGS > > > + bool "Export OEM strings in SMBIOS/DMI via sysfs to userspace" > > > + depends on DMIID > > > + default n > > > + help > > > + Say Y here if you want to query OEM strings (as part of the information > > > + contained in SMBIOS/DMI system identification) from userspace > > through > > > + /sys/class/dmi/id/oem/. > > > > Why wouldn't you want these? > > > > Jean Delvare would rather see this implemented in userspace dmidecode. > Jean raised a concern in an earlier submission that this runs on every > machine (https://lkml.org/lkml/2016/8/2/799). Ah, yeah, just use dmidecode, much simpler, keeps the kernel smaller, I like it. thanks, greg k-h