From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935363AbcHaOxH (ORCPT ); Wed, 31 Aug 2016 10:53:07 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59808 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933835AbcHaOxG (ORCPT ); Wed, 31 Aug 2016 10:53:06 -0400 Date: Wed, 31 Aug 2016 16:53:03 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: make switchdev DB ops generic Message-ID: <20160831145303.GE15078@lunn.ch> References: <20160829203246.18811-1-vivien.didelot@savoirfairelinux.com> <20160829203246.18811-3-vivien.didelot@savoirfairelinux.com> <20160831134943.GB15078@lunn.ch> <87shtlvw8c.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87shtlvw8c.fsf@ketchup.mtl.sfl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > No. mv88e6xxx_port_db_dump already exists, this is the function called > mv88e6xxx_port_db_dump_one multiple time. Here, _one refers to an FID > (forwarding database). 88E6352 have 4096 FIDs. So maybe s/_one/_fid/ ? Andrew