From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161136AbcHaRUK (ORCPT ); Wed, 31 Aug 2016 13:20:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43240 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161023AbcHaRUJ (ORCPT ); Wed, 31 Aug 2016 13:20:09 -0400 Date: Wed, 31 Aug 2016 19:20:07 +0200 From: Alexandre Belloni To: LABBE Corentin Cc: paul.gortmaker@windriver.com, nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory: atmel-sdramc: fix a possible NULL dereference Message-ID: <20160831172007.efsb3viemsemamnx@piout.net> References: <1471355598-11853-1-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471355598-11853-1-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-07-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/2016 at 15:53:18 +0200, LABBE Corentin wrote : > of_match_device could return NULL, and so cause a NULL pointer > dereference later. > > For fixing this problem, we use of_device_get_match_data(), this will > simplify the code a little by using a standard function for > getting the match data. > > Signed-off-by: LABBE Corentin > --- > drivers/memory/atmel-sdramc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com