From: Danny Milosavljevic <dannym@scratchpost.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.
Date: Thu, 1 Sep 2016 12:56:08 +0200 [thread overview]
Message-ID: <20160901125608.72808fac@scratchpost.org> (raw)
In-Reply-To: <CAGb2v64zA3iSOe7ku=pF0RhJkvErxt_tbPWG4H8D6r5UEUJAMQ@mail.gmail.com>
Hi Chen-Yu,
> I have a few patches that introduce SOC_DAPM_DOUBLE, so you can share a
> control between left/right channels. IMHO it makes the userspace mixer
> less confusing.
I definitely agree that cutting down on the number of sliders would be good.
I do a double-take every time I open alsamixer - and I *added* these
sun4i widgets :)
It would be good if your patch series was queued and I could use SOC_DAPM_DOUBLE
in a future version of my patch.
Can you post it?
Since it changes user space-visible API whether I group the widgets or not we
have to be careful about it. So far my patch has not been merged which is good
for API stability I guess.
I wondered about why there's a SOC_DOUBLE_TLV but no SOC_DAPM_DOUBLE before,
so it's good to know there's no deep reason.
That said, I'd have to remove the distinction between Left Mixer and Right
Mixer then. Right now it does distinguish.
Removing the distinction would remove noteworthy routes like
{ "Right Mixer", "Left DAC Playback Switch", "Left DAC" },
(not a typo). Would that be OK?
Well, let's see how it will work out.
In the mean time I added the second regmap and the quirks and will post another
patch series for comments.
Cheers,
Danny
next prev parent reply other threads:[~2016-09-01 10:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 5:44 [PATCH v9 0/2] sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2016-08-30 5:44 ` [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic
2016-08-31 3:22 ` Chen-Yu Tsai
2016-08-31 17:46 ` Maxime Ripard
2016-08-31 20:14 ` [linux-sunxi] " Danny Milosavljevic
2016-09-01 16:45 ` Maxime Ripard
2016-08-30 5:44 ` [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
2016-08-31 6:24 ` Chen-Yu Tsai
2016-08-31 7:17 ` Danny Milosavljevic
2016-08-31 7:46 ` Chen-Yu Tsai
2016-08-31 7:40 ` [linux-sunxi] " Danny Milosavljevic
2016-08-31 7:43 ` Chen-Yu Tsai
2016-08-31 7:49 ` Danny Milosavljevic
2016-08-31 7:55 ` Chen-Yu Tsai
2016-09-01 10:56 ` Danny Milosavljevic [this message]
2016-09-01 13:25 ` Chen-Yu Tsai
-- strict thread matches above, loose matches on Subject: below --
2016-08-29 18:03 [PATCH v9 0/2] sun4i-codec: Add " Danny Milosavljevic
2016-08-29 18:03 ` [PATCH v9 2/2] Add mixer controls: " Danny Milosavljevic
2016-08-26 7:22 [PATCH v9 0/2] sun4i-codec: Add " Danny Milosavljevic
2016-08-26 7:22 ` [PATCH v9 2/2] Add mixer controls: " Danny Milosavljevic
2016-08-26 6:53 [PATCH v9 0/2] sun4i-codec: Add " Danny Milosavljevic
2016-08-26 6:53 ` [PATCH v9 2/2] Add mixer controls: " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901125608.72808fac@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox