From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933514AbcIAPcI (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 11:32:08 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:52921 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932901AbcIAPcH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 11:32:07 -0400
Date: Thu, 1 Sep 2016 17:32:15 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: David Daney <ddaney@caviumnetworks.com>, devel@driverdev.osuosl.org,
        David Daney <david.daney@cavium.com>,
        Laura Garcia Liebana <nevola@gmail.com>, linux-kernel@vger.kernel.org,
        Aaro Koskinen <aaro.koskinen@nokia.com>,
        Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
        Cristina Moraru <cristina.moraru09@gmail.com>,
        Philippe Reynes <tremyfr@gmail.com>
Subject: Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of
 checking for built-in or module
Message-ID: <20160901153215.GA24505@kroah.com>
References: <1472133315-14640-1-git-send-email-javier@osg.samsung.com>
 <57BF1644.5060207@caviumnetworks.com>
 <ff2cfb41-50e0-4904-d685-0266c62ae4ab@osg.samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ff2cfb41-50e0-4904-d685-0266c62ae4ab@osg.samsung.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote:
> Hello David,
> 
> On 08/25/2016 12:01 PM, David Daney wrote:
> > On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
> >> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> >> built-in or as a module, use that macro instead of open coding the same.
> >>
> >> Using the macro makes the code more readable by helping abstract away some
> >> of the Kconfig built-in and module enable details.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> >> Acked-by: David Daney <david.daney@cavium.com>
> >>
> >> ---
> >>
> >> Changes since first post:
> >> - Added David Daney Acked-by tag.
> >> - Rebased on top of latest master.
> >>
> > 
> > You changed something about the patch.  In this case the Subject is not "RESEND", but rather "v2".  Incorrect Subject lines like this can lead to the patch being inadvertently ignored.
> >
> 
> Yes, in fact I thought about adding a v2 suffix instead of RESEND but since
> I didn't change the patch content (besides merge conflicts resolution), I
> preferred to add the latter.
> 
> I can re-spin the patch if that's an issue.

Please do.

thanks,

greg k-h