From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755496AbcIAPgo (ORCPT ); Thu, 1 Sep 2016 11:36:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52936 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754471AbcIAPgn (ORCPT ); Thu, 1 Sep 2016 11:36:43 -0400 Date: Thu, 1 Sep 2016 17:36:21 +0200 From: Greg Kroah-Hartman To: Andrey Utkin Cc: Anson Jacob , Staging List , arve@android.com, riandrews@android.com, Kernel List Subject: Re: [PATCH] staging: android: lowmemorykiller.c: Fix checkpatch warning Message-ID: <20160901153621.GA24685@kroah.com> References: <20160825151025.GA4399@X250> <20160825152647.ts6oq4sanxlbuneh@acer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160825152647.ts6oq4sanxlbuneh@acer> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 06:26:48PM +0300, Andrey Utkin wrote: > On Thu, Aug 25, 2016 at 11:10:25AM -0400, Anson Jacob wrote: > > Fix checkpatch.pl 'line over 80 characters' warning > > > > Signed-off-by: Anson Jacob > > --- > > drivers/staging/android/lowmemorykiller.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > > index 45a1b4e..80d7adf 100644 > > --- a/drivers/staging/android/lowmemorykiller.c > > +++ b/drivers/staging/android/lowmemorykiller.c > > @@ -92,8 +92,8 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc) > > int array_size = ARRAY_SIZE(lowmem_adj); > > int other_free = global_page_state(NR_FREE_PAGES) - totalreserve_pages; > > int other_file = global_node_page_state(NR_FILE_PAGES) - > > - global_node_page_state(NR_SHMEM) - > > - total_swapcache_pages(); > > + global_node_page_state(NR_SHMEM) - > > + total_swapcache_pages(); > > > > if (lowmem_adj_size < array_size) > > array_size = lowmem_adj_size; > > Indeed original alignment on opening brace here doesn't make sense. > I don't mind if your patch gets accepted, but out of curiosity I have opened > this file in vim with kernel coding style plugin loaded > (https://github.com/vivien/vim-linux-coding-style), selected the affected > lines, and reindented the selection by pressing 'gq'. It ended up with this, > being both shorter and simpler: > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > index 45a1b4e..3aef467 100644 > --- a/drivers/staging/android/lowmemorykiller.c > +++ b/drivers/staging/android/lowmemorykiller.c > @@ -92,8 +92,7 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc) > int array_size = ARRAY_SIZE(lowmem_adj); > int other_free = global_page_state(NR_FREE_PAGES) - totalreserve_pages; > int other_file = global_node_page_state(NR_FILE_PAGES) - > - global_node_page_state(NR_SHMEM) - > - total_swapcache_pages(); > + global_node_page_state(NR_SHMEM) - total_swapcache_pages(); The original patch here is nicer to read, don't you think? thanks, greg k-h