public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ding Xiang <dingxiang@huawei.com>
Cc: arnaud.patard@rtp-net.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging:xgifb:remove unused code
Date: Thu, 1 Sep 2016 17:48:34 +0200	[thread overview]
Message-ID: <20160901154834.GA1977@kroah.com> (raw)
In-Reply-To: <1471947819-26534-1-git-send-email-dingxiang@huawei.com>

On Tue, Aug 23, 2016 at 06:23:39PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
> 
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
>  		tempax |= 0x40;
>  
>  	xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> -	data = xgifb_reg_get(pVBInfo->P3d4, 0x07);

You didn't answer my previous question, I think this will break the
driver, have you tried this?

thanks,

greg k-h

      reply	other threads:[~2016-09-01 15:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 10:23 [PATCH V2] staging:xgifb:remove unused code Ding Xiang
2016-09-01 15:48 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160901154834.GA1977@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dingxiang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox