Re: [PATCH v2 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

Krzysztof Kozlowski
2016-09-01T16:26:43Z

On Thu, Sep 01, 2016 at 11:06:50AM +0200, Javier Martinez Canillas wrote:
> The skeleton.dtsi file was removed in ARM64 for different reasons as
> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>
> These also applies to ARM and it will also allow to get rid of the
> following DTC warnings in the future:
>
> "Node /memory has a reg or ranges property, but no unit name"
>
> But these boards don't have a memory node defined, so removing the
> skeleton.dtsi inclusion in exynos5440.dtsi will cause a change in
> the compiled DTB. Add a dummy memory node so the compiled DTB does
> not change if the skeleton.dtsi is removed from exynos5440.dtsi.
>
> Eventually the correct starting addresses and sizes should be used
> but I didn't find that information.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Add a fixme to specify that the correct memory values should be set.
> (Bartlomiej Zolnierkiewicz)
> - Fix commit message (Krzysztof Kozlowski).
>
> arch/arm/boot/dts/exynos5440-sd5v1.dts | 6 ++++++
> arch/arm/boot/dts/exynos5440-ssdk5440.dts | 6 ++++++
> 2 files changed, 12 insertions(+)
>

Thanks, applied.

Best regards,
Krzysztof