From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934993AbcIAQpP (ORCPT ); Thu, 1 Sep 2016 12:45:15 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51827 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934937AbcIAQpF (ORCPT ); Thu, 1 Sep 2016 12:45:05 -0400 Date: Thu, 1 Sep 2016 18:45:01 +0200 From: Maxime Ripard To: Danny Milosavljevic Cc: Mark Brown , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Message-ID: <20160901164501.GE20462@lukather> References: <20160830054403.7878-1-dannym@scratchpost.org> <20160830054403.7878-2-dannym@scratchpost.org> <20160831174623.GA20462@lukather> <20160831221402.670ab832@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ryJZkp9/svQ58syV" Content-Disposition: inline In-Reply-To: <20160831221402.670ab832@scratchpost.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ryJZkp9/svQ58syV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Danny, On Wed, Aug 31, 2016 at 10:14:02PM +0200, Danny Milosavljevic wrote: > Hi Maxime, >=20 > On Wed, 31 Aug 2016 19:46:23 +0200 > Maxime Ripard wrote: >=20 > > > -#define SUN4I_CODEC_AC_SYS_VERI (0x38) > > > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL (0x3c) > > > + > > > +#define SUN7I_CODEC_AC_DAC_CAL (0x38) > > > +#define SUN7I_CODEC_AC_MIC_PHONE_CAL (0x3c) =20 > >=20 > > That will need at least some mention in the commit log. >=20 > Hm? It's now called like it is called in the user manual. > Also, the macro SUN4I_CODEC_AC_SYS_VERI was unused before anyway. >=20 > What should I write in the commit log? For example, that the current code was wrong and those registers are not present on the A10. That way, you justify both the renaming, and the max_register change in the regmap. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ryJZkp9/svQ58syV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXyFsNAAoJEBx+YmzsjxAgzfkQAJ6kjfPBTn2jIIui4RhN0YjL bgL7E18nYEKIL5XIYeDwqVT8Fc9RRmKUHYFni0SrWEt7mNHb9RXvM1UeWEvWH/Qy ztu+WGfzNIqL+/JpZ4vOXKcGjF74Y21udUiIHPb0vLopGl9PQ8VRszgcnuZ1ojPt OcoKzdeYSnF3Kx3wQgxkx7Iw/28Od5BqgdnurdWVopAxLSzQvh17UWMnvVn6mSLb Bezp8AH6Xn2J+ts3LS4tfZwDkjGMt4hCUjZJpHGQUr9Z18oyo4gkfBH1ar6VR+SU cEpv4GXqNrrFrCEbMNOpeUL2jHyN/EQPKov3x9sRnp+Fg/cEg9h9xKHX2DEafsEp lzFKAN/Xyvuo0+0DhIvP0bWY3z9d+G7nGJRzhyGqcY5SFt/oLWJHb52yBDV6iQS6 bOSxzlab962CpwyQKceql1Dn4/CpN7/bw3dreWyH+RIpXXKt7kqqkJdL4pok9xpA Ljj5Ck5m6edkogKqOQTiT6LMMfQ2h5GZqAIlJf5TRtmVjxmBSvl5ukHVdN6x9/sv 675rDLq4w5zVJPqHPC5QTJrPwDi2UNYxE5Us6rjQhUR0zuopCNrjDyQXyv+rz6VC ivo73fNbvGuun0S5KOEGMabD6suzgAPzUuGzBmZnQlmB5wHFM5Q9qVWED7CRluKP 43HxGnVRg2YKQqLTJoe1 =lt8A -----END PGP SIGNATURE----- --ryJZkp9/svQ58syV--