From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbcIAV5F (ORCPT ); Thu, 1 Sep 2016 17:57:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59464 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbcIAV5D (ORCPT ); Thu, 1 Sep 2016 17:57:03 -0400 Date: Thu, 1 Sep 2016 20:19:53 +0200 From: Greg KH To: Sabitha George Cc: wsa@the-dreams.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c Message-ID: <20160901181953.GA6787@kroah.com> References: <1472752095-18559-1-git-send-email-sabitha.george@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472752095-18559-1-git-send-email-sabitha.george@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote: > This is a patch to the ks7010_sdio.c that fixes the following > warnings found by checkpatch.pl > 1) Missing a blank line after declarations > 2) braces are not necessary for single statement blocks > 3) kfree(NULL) is safe and this check is probably not required > 4) void function return statements are not generally useful > 5) "foo * bar" should be "foo *bar" > 6) Code indent should use tabs where possible > 7) printk() should include KERN_ facility level That's 7 different things, so this should be at least 7 different patches :) Please break this up and submit it as a patch series so it can be easily reviewed and applied. thanks, greg k-h