* [PATCH] staging: i4l: act2000: Add blank line after declaration
@ 2016-09-02 5:09 Anson Jacob
2016-09-02 5:29 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Anson Jacob @ 2016-09-02 5:09 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Kernel List, Staging List
Fix checkpatch.pl warning:
Missing a blank line after declarations
Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
drivers/staging/i4l/act2000/act2000_isa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
index 1d93151..fbb15f5 100644
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -259,6 +259,7 @@ act2000_isa_receive(act2000_card *card)
"act2000_isa_receive: Invalid CAPI msg\n");
{
int i; __u8 *p; __u8 *t; __u8 tmp[30];
+
for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
t += sprintf(t, "%02x ", *(p++));
printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: i4l: act2000: Add blank line after declaration
2016-09-02 5:09 [PATCH] staging: i4l: act2000: Add blank line after declaration Anson Jacob
@ 2016-09-02 5:29 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-09-02 5:29 UTC (permalink / raw)
To: Anson Jacob, Greg Kroah-Hartman; +Cc: Kernel List, Staging List
On Fri, 2016-09-02 at 01:09 -0400, Anson Jacob wrote:
> Fix checkpatch.pl warning:
> Missing a blank line after declarations
[]
> diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
[]
> @@ -259,6 +259,7 @@ act2000_isa_receive(act2000_card *card)
> "act2000_isa_receive: Invalid CAPI msg\n");
> {
> int i; __u8 *p; __u8 *t; __u8 tmp[30];
> +
> for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
> t += sprintf(t, "%02x ", *(p++));
> printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);
It'd be better to use the %*ph vsprintf extension
(see Documentation/printk-formats.txt) without
any of the loop code and variable declarations:
pr_warn("%s: %8ph\n",
__func__, card->idat.isa.rcvhdr);
or maybe
pr_warn("%s: %*ph\n",
__func__,
(int)ARRAY_SIZE(card->idat.isa.rcvhdr),
card->idat.isa.rcvhdr);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-02 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-02 5:09 [PATCH] staging: i4l: act2000: Add blank line after declaration Anson Jacob
2016-09-02 5:29 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox