From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Laura Abbott <labbott@redhat.com>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"John Stultz" <john.stultz@linaro.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linaro-mm-sig@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
"Eun Taik Lee" <eun.taik.lee@samsung.com>,
"Liviu Dudau" <Liviu.Dudau@arm.com>,
"Jon Medhurst" <tixy@linaro.org>,
"Mitchel Humpherys" <mitchelh@codeaurora.org>,
"Jeremy Gebben" <jgebben@codeaurora.org>,
"Bryan Huntsman" <bryanh@codeaurora.org>,
"Android Kernel Team" <kernel-team@android.com>,
"Chen Feng" <puck.chen@hisilicon.com>,
"Brian Starkey" <brian.starkey@arm.com>
Subject: Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking
Date: Fri, 2 Sep 2016 08:10:40 +0200 [thread overview]
Message-ID: <20160902061040.GB13294@kroah.com> (raw)
In-Reply-To: <1472769644-11039-4-git-send-email-labbott@redhat.com>
On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote:
>
> The current Ion ioctls lack a good way to tell what ioctls are
> available. Introduce an ioctl to give an ABI version. This way when the
> ABI inevitably gets screwed up userspace will have a way to tell what
> version of the screw up is available.
This worries me. Why do we need this? Shouldn't any "new" abi changes
just add on, and not change existing ioctl structure calls? Or worst
case, you remove an ioctl and then userspace "knows" that when the call
fails.
And who is the major userspace user of this interface? Who controls it?
How are we keeping things in sync here?
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-02 6:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 22:40 [PATCHv2 0/4] New Ion ioctls Laura Abbott
2016-09-01 22:40 ` [PATCHv2 1/4] staging: android: ion: Drop heap type masks Laura Abbott
2016-09-02 13:41 ` Brian Starkey
2016-09-02 19:36 ` Laura Abbott
2016-09-05 11:20 ` Brian Starkey
2016-09-06 22:16 ` Laura Abbott
2016-09-07 8:50 ` Brian Starkey
2016-09-01 22:40 ` [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file Laura Abbott
2016-09-02 12:44 ` Greg Kroah-Hartman
2016-09-02 19:53 ` Laura Abbott
2016-09-01 22:40 ` [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking Laura Abbott
2016-09-02 6:10 ` Greg Kroah-Hartman [this message]
2016-09-02 20:26 ` Laura Abbott
2016-09-02 9:02 ` [Linaro-mm-sig] " Arnd Bergmann
2016-09-02 20:33 ` Laura Abbott
2016-09-02 21:33 ` Arnd Bergmann
2016-09-02 22:14 ` Laura Abbott
2016-09-01 22:40 ` [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps Laura Abbott
2016-09-01 23:44 ` kbuild test robot
2016-09-02 21:27 ` Laura Abbott
2016-09-02 21:37 ` [Linaro-mm-sig] " Arnd Bergmann
2016-09-02 21:53 ` Laura Abbott
2016-09-02 6:14 ` Greg Kroah-Hartman
2016-09-02 20:41 ` Laura Abbott
2016-09-03 12:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902061040.GB13294@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Liviu.Dudau@arm.com \
--cc=arve@android.com \
--cc=brian.starkey@arm.com \
--cc=bryanh@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=eun.taik.lee@samsung.com \
--cc=jgebben@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
--cc=puck.chen@hisilicon.com \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox