From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbcIBMzn (ORCPT ); Fri, 2 Sep 2016 08:55:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50193 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbcIBMzm (ORCPT ); Fri, 2 Sep 2016 08:55:42 -0400 Date: Fri, 2 Sep 2016 14:55:49 +0200 From: Greg KH To: Louie Lu Cc: linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, amitoj1606@gmail.com, bhaktipriya96@gmail.com, punitvara@gmail.com, laerdevstudios@gmail.com, shivanib134@gmail.com, devel@driverdev.osuosl.org Subject: Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Message-ID: <20160902125549.GA26074@kroah.com> References: <20160902101610.GA9040@gserv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160902101610.GA9040@gserv> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote: > fixed comment style and space indent report from checkpatch: > > * WARNING: Statements should start on a tabstop > * WARNING: Block comments use * on subsequent lines > * WARNING: suspect code indent for conditional statements (16, 32) > > Signed-off-by: Louie Lu > --- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++----------- > 1 file changed, 22 insertions(+), 15 deletions(-) This patch adds errors :( Now if you want to constantly submit new checkpatch cleanups to the driver, that's a good thing, but really, please use checkpatch on your patches to ensure you are doing things properly. I'm dropping it from my patch queue. thanks, greg k-h