From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbcIBNUH (ORCPT ); Fri, 2 Sep 2016 09:20:07 -0400 Received: from mail-bl2nam02on0047.outbound.protection.outlook.com ([104.47.38.47]:20061 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751055AbcIBNUF (ORCPT ); Fri, 2 Sep 2016 09:20:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Fri, 2 Sep 2016 16:04:53 +0300 From: Yury Norov To: Arnd Bergmann CC: , Bamvor Jian Zhang , , , , , , , , , , , , , , , , , , , , , , , , , , Andrew Pinski , Andrew Pinski , Hanjun Guo , chenjianguo 00365834 , jijun 00321192 Subject: Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160902130453.GA14229@yury-N73SV> References: <1471434403-25291-1-git-send-email-ynorov@caviumnetworks.com> <1471434403-25291-13-git-send-email-ynorov@caviumnetworks.com> <57C9587B.9080006@huawei.com> <6815916.BISHOLF1Ut@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <6815916.BISHOLF1Ut@wuerfel> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM5PR0101CA0021.eurprd01.prod.exchangelabs.com (10.169.240.31) To CY1PR07MB2248.namprd07.prod.outlook.com (10.164.112.150) X-MS-Office365-Filtering-Correlation-Id: f6ed8ff2-83db-43a7-fc6d-08d3d331c0d4 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;2:L7M3Au3E9zaw05bh97WN6IBpy/IpRmuDDyawNoPrTNkhLzMv5zYDk6bwcH6a823mjBhA8GLrRxboANCpv2az65F+ZBbsUUWs990RWE7u1mNaWAf/74ABY/JfQnPD0foYPY9O/uknZDpzzvpxz1H05KVcDZPiFxTdzUL7xa07h+BKJb9uIPVmylkHWP7W8/2U;3:3NqcM9aaTHoZlpJZzc7toAR2USyQEPETSOS2EFzaWVCS/4mJr32f5TWuItq6BiHxwLeg+B9iQZLrw2sHTJqB4j+AOkvwiZc5zpC/jy9EQAeGDias3mOn/WtF8bB7pWz5;25:Lpk1/mI/xOVkGyOFtfn9f2Mb7N5zln081BWSWMKbRM594cmXwEDMMb83mWj4LVVVzPNZ9ccgEr0yI5kLzD60Payd8W1aHqCYSlgrbsPtQO2Lx7PPX+R2KTvasezXLMUQa5UUSvAvcjWxN8xBeeEMMmyMW6aOCIY+LEI5erbW3GbkltCCkrXslemOK1K5VqpJ94MRIbWz09eX06AF5K4EonCm4PGVk88pR9lhXJFoXSPm1Xmvs0Ecfs9PWrW+FKajZE9g10jWmTw+HhZCnWuK9Su1hJ9VAIFt8/c0IWyxcnj/8Izpij/Obpb2WidTPnVdXg/kPYGB6ohMZhOuuKm/0rOfFwUH2JMpiMSHGYeaJo9b3f1dtay+XQN8DAaExoktFY3zrNM4jthXYfoUXkXmA75UIcF+0T8qdMGqVlCysi4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2248; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;31:mc8FuUTxMM0kdoW4yg9y2+m+mcQYQQnNTuigzdYg7IFamoAHVQiLAnliIV/2cywnqBpdZ9FJ2MYlMW2OGQ7G20TVbYKpFTSByEvPPMdHHmYAKeOP3gU2rP0acDVrcaFJBhZs1BHC3hSdLfGGyli/751Gg4Kjk7/+xt83c7blQzf2KlDY3XfuhuEi0nzSsoJZ2OoxTDqP0Drh0ZyY0UGknDMQR/yvPGR1LE3XfnAXJjQ=;20:XTyO0g8IiTRKLWsiMTpmjYJKt5b8bJyyn/UK5Q3HwgOcjecucwwgxzptvfNsmchT/uWqm6v2CZQ9J4sPKAsqdodVcsy+VdSVDD4JVoQNii0PKjq4b+RPXGpv7mMo8GQw6hfev9arlsZ90KWx4zOLQ8shG94LJukVwLdUPAsihGSPFUqrTXpefKXKtg4K3NWOT38/b4wvh0kztAzkDEwUAbUk+0z+5a4B2x5KPyVmqffYPkg0PRicugAfXGdhbupBjKp0xObyHL/WXUMXvB6io45OZCMtXjaVb4pEcbjKMXU+0gByEfMBuTWCyCCjyBAUv+RKkwiVT02oJJpHbpWGWwVL7EszWOiSlBMiXypQuyAQMk8mDk4z30jkkKrZxBoWpLIIFh4FsTAzM4lBpLMwGhQL/orOdxT6oW0PCu9TV+2/y0ENBXNrQzisxqWds57N33lhEKcCmysPVX32DSnc3BDn0N8u3mHcCU3fSt6TOdG5fAuWrnd7VR3aHPkIgKk8gQjzNSli51oMgoqQIAq9AVoXMjUCDn8rhE9bvvAeGUZf5WDkHbkVtFWz1krBCSlfhv1zx9IyEaMKBUwWK6DMODLJneqeXyzNY4q5GjmJqLk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR07MB2248;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2248; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;4:YS4a0qYistHdQcIcQrlavtVOyAxDznvw5FMMBFQsR4x1+5AvIszYBSWOnBYCT4YmK+fksXmhmug9AEbCtvwS5LESFnvAYx6FyPeJHVR9eoB/ktjWezAhk/7SNhYV7p0PcWVs7riByP7YzLs5/0JHj4W3ES/vkZvsoKHtq+DsLWl8Wmc87bMVPXylPd3nl29Z7g6qQyFJ5Bl1m3+231HU+f6fMMGtgflX+7uBzFx6M3zF6k/ePSV+7PEBFPVeZ/uyNIc7gLStQxog0nKl7qA5sdwXIf8VOMlKcvSbVhBlSHFnv4H+nTtSh4hsExX7bxyw2HFGYGcZGz5zhxYrkHA4chew8aaynpEQckog3tx+gaEbiE0MpuYnmf2rSHcZ1gQTy0gLznGQuc+mjRYEZ6bTMQ== X-Forefront-PRVS: 00531FAC2C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(199003)(24454002)(189002)(377454003)(92566002)(7846002)(97756001)(101416001)(76176999)(110136002)(1076002)(7736002)(189998001)(23726003)(54356999)(6116002)(8676002)(83506001)(42186005)(76506005)(9686002)(586003)(97736004)(5660300001)(575784001)(33716001)(50986999)(4001350100001)(3846002)(46406003)(7416002)(106356001)(105586002)(93886004)(66066001)(50466002)(2906002)(81156014)(68736007)(7406005)(47776003)(33656002)(2950100001)(81166006)(4326007)(77096005)(305945005)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2248;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2248;23:GDRAuRxxphzyYYask3HqayKB52ngg8krzys1htTw6?= =?us-ascii?Q?zGINtwRZiy+rRW0NE8rbzoMigFOAvQFJ25HKZ4z7/sNiXUtYAUXPhnHjFfBg?= =?us-ascii?Q?CRJle9Mo2SWDitGNWfKjVXZr+Gaii8Ur93YeiAzfnxx2iCUAKXXi8PcHNSEe?= =?us-ascii?Q?7B1/dIuiTLDs6A3rxKud34EZQvlGyDRg/0oYt7CJEJAn6ZDARQEVSzW8gJCi?= =?us-ascii?Q?VyjITdyg4muiN+I0fwYEHu5nNWIqcheMCP08OZKE4fcjBoebCJRNRzFCo5w9?= =?us-ascii?Q?D+b8oFJSO+/iV/QFIBZ+e1ZJ7jaLQvEPy+m6xpgBSvAPU3IC+EUcjyr77Cr4?= =?us-ascii?Q?g7xKa2uDpvsVYeek52kYbyzZor1w3XVX0u3lamHigKXwLQ9q1HNRFxSp8j59?= =?us-ascii?Q?7ZIv8BHOP53kb0Co5U1HUS3vFX+T2zftDxIs5dWUo9j3i3n1UJAvAnOS6HYk?= =?us-ascii?Q?cu9DkgwaejEc17nESyfGb88+DqhgdRGBr550sgfprDhFe49tM5/yzwZMkcMK?= =?us-ascii?Q?V3UOSnWPsHl+hrEfmhcXsvIRKsxSbErj9nnoAnxyfs/mkaNs3XSANl2KZP3Z?= =?us-ascii?Q?JhbmxL2dBnEjDnghciha+p9EXsEhTcHW3byzqEBTcbck9KheGu/+sICe5z1h?= =?us-ascii?Q?McFQgHpVpOHbqJ5p/LUhcS9Qcu+65YdhoM2MxR22ZwCiKiFc3RVtwFC5yI4p?= =?us-ascii?Q?nigW+5IKXduZn4bDQJH8W9BBwr6vvnF52BM+I9I2/ixosMfx+EnhE0TiouUT?= =?us-ascii?Q?n+pojEV0Tork1c92TtOwJ+ZEyeSAEAPnxHH1iftR42/HCiUG03RIT1Mvv2ix?= =?us-ascii?Q?EeVgchk9FUt/9qCjOEiki4rgEGGTB3nf+UemDhuhTAsU74gpLlSHJmiRtMGD?= =?us-ascii?Q?LQIVDrmRuRUrlZCMXfFJkDRtB3ZrZeBlMIZujGU9irghDl1908OPZitIIY/T?= =?us-ascii?Q?3yApabbeHEBE40ger6KfH5l9lwjdlKJeR43hLq4RYG5Qsaqn1ZAz85m9bMbX?= =?us-ascii?Q?xdF0v3ObrR/SIkTkCYk5MuKBMPkPfRn3ZvuSKW/CkONvASJzwX3HzC8hkLex?= =?us-ascii?Q?VM+SFynWW3VImCtBpHroj71Oz51Wfz+vnfnYZp5Dw3IhGv1pAZhvP8EPZgQI?= =?us-ascii?Q?iEe2tybrYh3AX7AOEl7cQGzUoI5N1wxFdOO8ZOQD9/7E7hRtaE7hgjh6Hgdg?= =?us-ascii?Q?e0uF0CmxgJRAkNcJggdxideuBvTDkSoyNdfkcgyYSE2m9JPPdiJcGEd7vlps?= =?us-ascii?Q?KIlNnkdl5iFiol2hKiCzEuSM2sZEWAQBeysRO2H?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2248;6:yOqJEmhJLCOoj5E4wYyzXdS/1Qvdm0w0BgEKjNyC3Sn0OpLYdeL+8JWLgK/5msgIeoK/xl9cP4boQNi99S7QRtM5W3QmsMFgtZldg3KxcTTCF3DoYnlkva051I4BHjkBrrf5Bn2SoyNSiKF6IJAdJX1lWef1CFi6ndHZCQ+qABVl8NjhTxWEAuvmQzdtxr0aEZ/IzcHx4/QdVsiQjUcQ2IK66w/vfkuVohTbxm7Wk2oDEjM1hnv+un7663t5zfkxen28Ui79wDviy3or9NPq3pPLKF/p2/4SReyXCVLAScU=;5:KqN+o8jd/DzYexAsvD3aO21Y1JIc4MYdUx8CniaEtlLHht90NicBofpKlafdAO8rvpFA5C1peXOZwmEvKnB06LUSY0Dyth5bOqFLh+iYhH7d6auY0Ii2TtfHnng0D2EkMqfoIag/vq99gWu9lQJZgw==;24:XpCHuuyoo0G+rFbfb/zOCMizx1cP6Vn2UGVYOtjZ9YFz1ph8hYbUUt5LvNWnXGIgzTiEOiJipLzlGHu0bv3FuBWz2LS9Z5g+B7Ml9cXXEwE=;7:ODukGsVFxmgeZFfZ+G94+9eAuDcFhu5ccqVmSVyBryTTJS5vHpESCudi2nSODV8X3E73h0SEoiHJZvJMYWQmeKuovGr8qwQOXKlxtYPwRWz6ir6UKlhkwow6T8GUXSmqpCQDm+r4FAvGsSldXqzPNkIZMqYNY6ZTu8CLcbVTAiArMnT9BzfNCaaPcFEZByJ1dReM68v3GXS2+WKpw+OTVODirlcJPcNV1GtfhmrMtDws2fdFNbY2iEWRs/MSOI0v SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2016 13:05:02.7360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2248 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2016 at 02:55:34PM +0200, Arnd Bergmann wrote: > On Friday, September 2, 2016 6:46:19 PM CEST Bamvor Jian Zhang wrote: > > diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h > > index 043d17a..78bea1d 100644 > > --- a/arch/arm64/include/uapi/asm/unistd.h > > +++ b/arch/arm64/include/uapi/asm/unistd.h > > @@ -16,4 +16,9 @@ > > > > #define __ARCH_WANT_RENAMEAT > > > > +/* We need to make sure it works for both userspace and kernel(sys_ilp32.c) */ > > +#if defined(__ILP32__) || defined(__SYSCALL_COMPAT) > > +#define __ARCH_WANT_SYNC_FILE_RANGE2 > > +#endif > > + > > #include > > diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c > > index 10fc0ca..13c9c9d 100644 > > --- a/arch/arm64/kernel/sys_ilp32.c > > +++ b/arch/arm64/kernel/sys_ilp32.c > > @@ -42,7 +42,7 @@ > > #define compat_sys_pwrite64 compat_sys_pwrite64_wrapper > > #define compat_sys_readahead compat_sys_readahead_wrapper > > #define compat_sys_shmat sys_shmat > > -#define compat_sys_sync_file_range compat_sys_sync_file_range2_wrapper > > +#define compat_sys_sync_file_range2 compat_sys_sync_file_range2_wrapper > > #define compat_sys_truncate64 compat_sys_truncate64_wrapper > > #define sys_mmap2 compat_sys_mmap2_wrapper > > #define sys_ptrace compat_sys_ptrace > > > > Looks good to me. > > Arnd Thank you. I'll take it. Yury.