From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbcIBNHb (ORCPT ); Fri, 2 Sep 2016 09:07:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50284 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbcIBNHa (ORCPT ); Fri, 2 Sep 2016 09:07:30 -0400 Date: Fri, 2 Sep 2016 15:07:36 +0200 From: Greg KH To: Louie Lu Cc: linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net, Florian Schilhabel , Amitoj Kaur Chawla , Bhaktipriya Shridhar , punit vara , Parth Sane , Shivani Bhardwaj , devel@driverdev.osuosl.org Subject: Re: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Message-ID: <20160902130736.GA2833@kroah.com> References: <20160902101610.GA9040@gserv> <20160902125549.GA26074@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2016 at 09:04:29PM +0800, Louie Lu wrote: > 2016-09-02 20:55 GMT+08:00 Greg KH : > > On Fri, Sep 02, 2016 at 06:16:10PM +0800, Louie Lu wrote: > >> fixed comment style and space indent report from checkpatch: > >> > >> * WARNING: Statements should start on a tabstop > >> * WARNING: Block comments use * on subsequent lines > >> * WARNING: suspect code indent for conditional statements (16, 32) > >> > >> Signed-off-by: Louie Lu > >> --- > >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++----------- > >> 1 file changed, 22 insertions(+), 15 deletions(-) > > > > This patch adds errors :( > > > > Now if you want to constantly submit new checkpatch cleanups to the > > driver, that's a good thing, but really, please use checkpatch on your > > patches to ensure you are doing things properly. > > > > I'm dropping it from my patch queue. > > > > thanks, > > > > greg k-h > > Hi Greg, > > sorry about that I didn't know I add error to this file. > I'll make sure this won't happen again. > > And if I want to resubmit this patch 3/3, I'll only need to resend this one, > like [PATCH 3/3 v2] this way? I've already taken the first 2 so just send it as a single patch. thanks, greg k-h