From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405AbcIBPc1 (ORCPT ); Fri, 2 Sep 2016 11:32:27 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33418 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932236AbcIBPcY (ORCPT ); Fri, 2 Sep 2016 11:32:24 -0400 Date: Fri, 2 Sep 2016 17:32:19 +0200 From: Thierry Reding To: Dmitry Osipenko Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/tegra: Expose color key and plane blending controls to userspace Message-ID: <20160902153219.GA396@ulmo.ba.sec> References: <20160902093359.9063-1-digetx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline In-Reply-To: <20160902093359.9063-1-digetx@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2016 at 12:33:42PM +0300, Dmitry Osipenko wrote: > Chromakey is a simple way of video overlay overlap implementation. This > patch adds 2 new IOCTL's: first - sets color key and is common across of > all Tegra SoC's, second - sets plane blending controls and allows to > utilize the color key, this one is exclusive to Tegra20/30. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/dc.c | 150 +++++++++++++++++++++++++++++++++----= --- > drivers/gpu/drm/tegra/dc.h | 6 ++ > drivers/gpu/drm/tegra/drm.c | 159 +++++++++++++++++++++++++++++++++++++= ++++++ > drivers/gpu/drm/tegra/drm.h | 14 ++++ > include/uapi/drm/tegra_drm.h | 34 +++++++++ > 5 files changed, 337 insertions(+), 26 deletions(-) I think these are really nice features to have, but these would need to be exposed as properties, rather than custom driver-specific IOCTLs. It seems to me like the colorkey feature could be implemented in much the same way as in the Armada, RCar and Nouveau drivers. As for the blending options, I think they should be exposed in terms of the zpos property, to allow generic userspace to make use of them. Also can you explain why this needs to be exclusive to Tegra20 and Tegra30? Thierry --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJXyZuAAAoJEN0jrNd/PrOhvJkP/iuNG5UBPC3uf2TYy5u2UgSh t2j3n3E4zmfzCrtB60G0Udt/v5LVk9POiGIQrfgidXqbeKeuiWYbLW9Bp9KDGPBE 5HhgJlUMpIKgzGJwnxvM5XxM6/mJuxxLVFPPmWadrH7JIMXgV6ADy45gBd+MbLrv MYVi9xAhumHJq225cTSkHinYY1+HkWOg30DRxL2/kvWeCvkjnVjyLL0dr2mzL4pK 56GErgwFI+1CkjbjMCpy/00QN/3J1QJjIPxqCMV8uqXysszQ57RCROOT+M7TKcFb HS1xdRIOC110TO50CXwhYg2fQRmQ+tKnXV7s1yeSiiW4Kdut3j0bHAZO73BbsjZK dCkhSh9Ewq8YQS8U2i2iKYdapFP3C9eoOcrXY2eJ2vNnvMXDehyXugW2tRI7ZoQb Q9X3LNK69ekGw3fCef85yuCGedHXSScpQRmYOELQwnIxUtwdb9bbu4ooiaIsEQBx kgdCEvIhV/QmhqrclQ0SiUP5BEtoUTPiFkzVdd4Qqe3T/1L/kyj0cxb/Xtwi3xpS A3quEjMGLQFbN1tGtqQFdXbxwrYHHwzWj1K/8IhvgeL9NKayUP6CVL+CgSYpXQ5s kGroGXnZSFyw8KSg343BILKrgn7Hpmi196h22VfGKInuPhlMgkbP5jAfPav+VSOx p8n/44FASKqwu3yQckXI =nPNp -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--