From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932777AbcIBPv2 (ORCPT ); Fri, 2 Sep 2016 11:51:28 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34972 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324AbcIBPvZ (ORCPT ); Fri, 2 Sep 2016 11:51:25 -0400 Date: Fri, 2 Sep 2016 17:51:20 +0200 From: Thierry Reding To: Dmitry Osipenko Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/tegra: Expose color key and plane blending controls to userspace Message-ID: <20160902155120.GB396@ulmo.ba.sec> References: <20160902093359.9063-1-digetx@gmail.com> <20160902153219.GA396@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xgyAXRrhYN0wYx8y" Content-Disposition: inline In-Reply-To: <20160902153219.GA396@ulmo.ba.sec> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xgyAXRrhYN0wYx8y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 02, 2016 at 05:32:19PM +0200, Thierry Reding wrote: > On Fri, Sep 02, 2016 at 12:33:42PM +0300, Dmitry Osipenko wrote: > > Chromakey is a simple way of video overlay overlap implementation. This > > patch adds 2 new IOCTL's: first - sets color key and is common across of > > all Tegra SoC's, second - sets plane blending controls and allows to > > utilize the color key, this one is exclusive to Tegra20/30. > >=20 > > Signed-off-by: Dmitry Osipenko > > --- > > drivers/gpu/drm/tegra/dc.c | 150 +++++++++++++++++++++++++++++++++--= ----- > > drivers/gpu/drm/tegra/dc.h | 6 ++ > > drivers/gpu/drm/tegra/drm.c | 159 +++++++++++++++++++++++++++++++++++= ++++++++ > > drivers/gpu/drm/tegra/drm.h | 14 ++++ > > include/uapi/drm/tegra_drm.h | 34 +++++++++ > > 5 files changed, 337 insertions(+), 26 deletions(-) >=20 > I think these are really nice features to have, but these would need to > be exposed as properties, rather than custom driver-specific IOCTLs. It > seems to me like the colorkey feature could be implemented in much the > same way as in the Armada, RCar and Nouveau drivers. >=20 > As for the blending options, I think they should be exposed in terms of > the zpos property, to allow generic userspace to make use of them. Also > can you explain why this needs to be exclusive to Tegra20 and Tegra30? Ah... I just realized that the blending interface changed on Tegra124. All the more reason to expose this more generically, that way we can hide the differences between a property and support the same interface across all generations of Tegra. Also see this: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/de9295aa= bdb7f80555c9b77b29ac77bcdac3280b Thierry --xgyAXRrhYN0wYx8y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJXyZ/2AAoJEN0jrNd/PrOhI+UQAJK0lj2PTwGKzELJjZ8PlrgR xoSt6q0hcX2KAcBZ+3NebnD3g2Gx5aQDZQ4Kyy8vptnSeLGhMQ8YWjscXwGAi2mQ IWaTv8Tx9xEOwoXYQXNUL+qPvOIds1Hr9Rj2/wX9lld4DVqOA8XhkDhYg1wHpXEE yxlhq8JDlu1hbw32e4xc/bortmO5B0BjUIitLpepUzRIwBvCdkK8UAkyjBGQNkHy KrWA+vKNt+C1c5jxzoaE0I6uxB7ZQQgBCDBmnNm8AqkZmnAwaspnP6tSDXgiak8s 3UCMlPkHHN5CkVbdDeWCgzrYnbNZyNyCd5EzPYWBQkThonvfUpk7UWIXIbaHQuKq lKS6OJTKha+DMOEacZuEin10WXCFwovjl6oqmD3QpTkVAmuRNKAl5ierFZxwLqkH wq607Dtmg1tX2J3zzRrrQkio6c9lunFIY5Lx3/N02E5SqotGjPdje710voY/UexJ 7kQ+dPxCQledga1Km1M4Uk9A9br2nfBuwH1JpFo4ZC0tcWKiSDtR3nZ/46bEmfzK X489REIS8v2tbWQQBYWOD5is0+dn1diwSUf2Ft5aI1D+EBo08y8aITf+8Yx5ES5U yjNdQrjN4mChtXuPmBCGjJUcXRB0f5nSBUyt4ZiiUlww2xfvzqa6WkmJ2oMM14kw UU6yyocYrLazA1s3LSlK =gI9X -----END PGP SIGNATURE----- --xgyAXRrhYN0wYx8y--