From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932614AbcIBQLx (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Sep 2016 12:11:53 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:34068 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932357AbcIBQLv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Sep 2016 12:11:51 -0400
Date: Fri, 2 Sep 2016 18:11:48 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@savoirfairelinux.com, "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code
 optional
Message-ID: <20160902161148.GK16864@lunn.ch>
References: <20160902120819.10773-1-vivien.didelot@savoirfairelinux.com>
 <20160902120819.10773-4-vivien.didelot@savoirfairelinux.com>
 <20160902145511.GH16864@lunn.ch>
 <87k2eugwcs.fsf@ketchup.mtl.sfl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87k2eugwcs.fsf@ketchup.mtl.sfl>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vivien

> What do you think?

I think the probe() needs to fail with a very obvious error message
saying you need to recompile your kernel with option XYZ enabled in
order to support this switch, when the optional stuff is not
optional...

	Andrew