Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

Steven Rostedt
2016-08-29T22:59:28Z

On Mon, 29 Aug 2016 18:58:13 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 25 Aug 2016 18:21:09 +0300
> Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>
> > It's useless. Before:
> > [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > -bash: echo: write error: No such file or directory
> > [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > -bash: echo: write error: Invalid argument
> >
> > After:
> > [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > -bash: echo: write error: No such file or directory
> >
> > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Actually, this patch seems agnostic to the series. I'll just pull it in
now.

-- Steve

>
> > ---
> > kernel/trace/trace_uprobe.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> > index c53485441c88..a74f2d9ff379 100644
> > --- a/kernel/trace/trace_uprobe.c
> > +++ b/kernel/trace/trace_uprobe.c
> > @@ -427,10 +427,6 @@ static int create_trace_uprobe(int argc, char **argv)
> > pr_info("Probe point is not specified.\n");
> > return -EINVAL;
> > }
> > - if (isdigit(argv[1][0])) {
> > - pr_info("probe point must be have a filename.\n");
> > - return -EINVAL;
> > - }
> > arg = strchr(argv[1], ':');
> > if (!arg) {
> > ret = -EINVAL;
>