Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe

Srikar Dronamraju
2016-08-30T14:58:19Z

* Steven Rostedt <rostedt@goodmis.org> [2016-08-29 18:58:13]:

> On Thu, 25 Aug 2016 18:21:09 +0300
> Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>
> > It's useless. Before:
> > [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > -bash: echo: write error: No such file or directory
> > [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > -bash: echo: write error: Invalid argument
> >
> > After:
> > [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > -bash: echo: write error: No such file or directory
> >
> > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Agree.

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

--
Thanks and Regards
Srikar Dronamraju