From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752997AbcICJKW (ORCPT ); Sat, 3 Sep 2016 05:10:22 -0400 Received: from mail-by2nam03on0046.outbound.protection.outlook.com ([104.47.42.46]:15508 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751127AbcICJKS (ORCPT ); Sat, 3 Sep 2016 05:10:18 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.22) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=permerror action=none header.from=amd.com; X-IncomingTopHeaderMarker: TopHeader Date: Sat, 3 Sep 2016 17:10:11 +0800 From: Huang Rui To: Baoyou Xie CC: , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] drm: amdgpu: mark symbols static where possible Message-ID: <20160903091010.GA3730@hr-amur2> References: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IncomingHeaderCount: 16 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:165.204.84.22;IPV:CAL;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(428002)(189002)(199003)(24454002)(626004)(50466002)(305945005)(189998001)(8676002)(101416001)(4001350100001)(1076002)(9686002)(76176999)(54356999)(26826002)(23726003)(11100500001)(2950100001)(110136002)(7846002)(50986999)(83506001)(19580395003)(4326007)(19580405001)(97756001)(47776003)(106466001)(105586002)(586003)(33716001)(5660300001)(8936002)(86362001)(246002)(46406003)(7416002)(356003)(87936001)(92566002)(33656002)(77096005)(2906002)(18370500001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR12MB0036;H:SATLEXCHOV02.amd.com;FPR:;SPF:None;PTR:hybridsmtp02.amd.com,hybridsmtp.amd.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM03FT053;1:QHNnfNagz4CfvtnMa/rOWIwUXycH9hR9Azmj+nNR96CRHJCuqkS3r6vuEhtCpK7s/47n5wQ7MeqbjKk9bN5UVYiuobExXZxCcNIVqfM9gzAYa7eRGXVeDr4FyC7pqiDQCKe8AGAqIoa33JuYlI4yf/oU3HRcs5coFMUsgpTX3Xqr7/VYizZBMIOI/Rwmr5360qY4LrzZATbkz6QtCcn9URw9XiIxmGy827GT42SV+JbGTx2vBYjo0JrijCklPVbS/K5ovxfS9sLsTLGKuD3M9qEl/+9eqY2JBkr4oGH1pmxoEY6EDuBqmMzPJq+9bZYG+LbkNgUqEq2RzAUQPNzkb+jaz3dTzdYV96qfVbBD/dBB8v7iFufEnyOUizSxg3BE4bQGC3xL1nL4E+e+NL4uyrAhaZqpRBFnt1dya5SGfgqVK07HvV9SbMA/szpmSrXdOTZcq9zU6Xw9uqrWFz9AG8Xz/FGgMLpatJ03ublNzrZn/kcEj0kqjhOFS0xoK1kvFbnYKgz7WYtSCg7Pa55ap0PlcoNQPiapGhuI5bdT3FwO9GUir04ougLs1NZS+TwE X-MS-Office365-Filtering-Correlation-Id: 53a383df-f4e1-4993-a2c6-08d3d3da1db8 X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0036;2:MNpYc4Bt3jA7hz8eo7ZqEJWBU0/22shDg8o7OQp2JUiqELKLlIyexDAn+LBTbaQZTviddzcU2kzQNr3LJsViopiETl79bpgIuZW0EWuKXGESa9K8o81aoosxXbw7MdFcB5VnztpuS5AjE5uUd/gw9KbH/osYBwBRffG1tUyhyUqfT3O1ujAGIOaFl6CTQjgv;3:hhCT3UdvGwFv+OX6kkyyfbnMLxQZFLzh2tQjxXbMwk5ONqrfWw4CmJ8WfQe/wJC0rXQVlvzTgJt5g+oLOVvTsTRLrvl25+drlg7GPolgaR2qUKIJN3uL5/y5Kr/2Khs9ya/14Ge6bX9/2L7kGRFuSQcAfGVLazIAguZZ3m1akQ20tKWGgETBOkC34SHAcC0J89qCGHofiz/8yHkvTZcKGUjl+sNFCAm6E4mM2k+dk/E= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR12MB0036; X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0036;25:TsW3rp7gPNQdXavJb9UH0QXimQpeJDw/BEyhPlAegxE6/f6W8evg26DZBYsaLvzHwSYKd5YnedqTQHghqZg6yEDLjqMKn6xc5HoKBwCsUYhRorf1OPL/eL3n6RV+/9qbqt1VasHaLmZRmCbHbMgmMfgrMt8xxGfoBY/Ilf9ADr5fLNkTdGezxV85FtyhBtKjLMzP5JK7kXpnAl2WYLvNeELY1h32suTt1zV5gFWy/7yVGYOXdvZSHknUK1IAK3iX0JhuebbOqSwQWtIXDz57ukcjPc6m0x4bk5U8w51bLgcbqrd7J4Dh95mgiEOCZDImynyP36pL0oeOsXRIuOqs8HTlF4JpkO5AWJ2omPN8PMCQD/KCj17KM6+5LnUDojtBVZbjACFccNECodo9lzU7BUKavvVn0euSQjEjssgyyHFT4Oi0TL3f+s36mKJsqH5KvfOMBUuGwMrpTN5Wo8owFzgUm6Hf3xgaAcXKoqHSmUUJZ3wR6BVtFXHbZ8mo0JRV0Fx5PW/U7NrAtyAZVfhtc1LZ5ev8zv7Hz/bivSqhB0AELDYlJidROYgSupL4REtEpNP2ch26XI+iL/PHH7dWX4mk5omSc7yaYO/2hcKMmRpc3f2IHBrDtclJ73QVmzKe74yAFn4ngJDPzrdIp909bIYx3wTn734ZZF1sywZ7qip1/3q82uOn3iDhq8Mjt9MzOwDSUFuKNuoqr41VkVa/gvRrzQ8ADDrZ6ZQkRoIcKf5rjipuwyoj6nXvpuY3bCpJ X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0036;31:Q8gzRT8jrI/Dm0uf4W1OvhaFBYu3Cg4UWCB+grHiRL19E0H98ZdaWdwB9pTto7uSBdGbrO94DFPBiQlzPiAfYPt7cGGpq4riT9EX1F3qAm0mE3UgGrqKVx+sgko5ojMMjdblsftH3CtedPIpvfT/oZe5FLVm/bZzM/gx5P0kH5RJJS15pvZN9mtTk76oHnHeoIf32FsJHFRDKLfav74+uMEUNyelWHQWn9V+8shGCYE=;20:BzLYUC4YuyPN8VByB0Aaskl2oHWEr6hs42dPly64uH70e36S/rTgN2V4pNt+NW8ay5gYSGld7zPjVO7ejJcduPtuYSh6BNzYuEs9aeRCTH/BXWv+sx93zWwUuxS+ge8B/sJPLcBvMg7c0C2feAcEyU3EA/pyD+GTvE9lFQNNtIyxhRAlgkXKjvpyPrOt+xxVJYbDwlcvf5O5jVDXNiLG58Zcsd8ff96JBHhqbSeH0PHrtrvdVuxGi4vzDIKmovV61d0nI0d1JNGbE2cKtnjV3CIiQFRe/6AcgRq+OsWLr9dLjVr1OV5sPlRs/R/Ket0LAczT8QbOM5HZl//cDpu4DL6fEEvkoPj2fEk8Gtt2zdNDyjVnJNx0FrA5tXEl3PPYTAM0RZdyqkBx+UfFkmpLk2/9HlKTnPgNWK2/2XsQsRCoNgjkEqzP/Co2ltWr7VoB4K2svYdvBEclg5znudJvTOfPZt7DOdC4WLDyf8S0rCC1RcAp63Ue6aK9quofNQhl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13023025)(13021025)(13013025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:BN1PR12MB0036;BCL:0;PCL:0;RULEID:;SRVR:BN1PR12MB0036; X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0036;4:AukDDhrO0aSe9UzwFGbVWRSh5PDSTt5qJg7U3CIhFhVUWx5hkakEZi3iAhK5jB9eYX2pBxXRe4kX6MQvbk7COO0hEyHNoZnVg8njw2vCxWzcs6KAw7/MkpFBgfDjI0Re3rdDkh/NuGM7avhi0aWwJuV5zAp+MeNWpGxr5+WF7xqArdVwHQwHJ+r1v7qq7N1WUk0k9JSv8cRTONbXjP8qsOdjmgbFmVrds7sRLKZzRO7rZOAzUbXwK/o2Poydp5Hov1tl8bqSh9ZhqkxM+MqL+pUQ1c0udcJdHwCubTHLUQ82cXGQC6dltg6tpdrIQu+b14RjCXjZGsRVxnodSWdcFMn7fci/yZSUR9kn1KTOzZktoIwIatKSQMN+8hLb2pz3y5uhUbULGrcdGvdds4iXLJBd9IjPJPKfZIv84cdyDP5GpVhMOTTyShdSHy4WnbhbC8gb13LiEoZqtf5ZnRjE+QM7XA0VAjYMeulPnRqLEST0AlnpcK7HYa+JNeotfahX X-Forefront-PRVS: 00540983E2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR12MB0036;23:ZZxguMioeZa+irVI6l8jWIIZy1rrXCAZCNE/QRdTf?= =?us-ascii?Q?iWjPHT8vzz1l2xihR+pmA7G5I5k4DET2puLRSuEzQOHYVKEgl+XCenXrbL3P?= =?us-ascii?Q?SMarvpVa3OndSt5nNbVI9NyzdAExdb1eF7eOgiq5PNF8iGAkAG+CBOxYierm?= =?us-ascii?Q?IUd596WJ5ItNVQOzqySMmZpDPklHnA+DCGd5+iDdOXmOOpbcOl/X7obdqbJn?= =?us-ascii?Q?gZLf6QVXDdWeZZVkbMBhaRfpICbaoYYnnvkXYTpxtbVm3OZt2qiqenQN+bJT?= =?us-ascii?Q?tBUC0Ozl2ItfSvXN/C3pxfU0cOFSOIqWYtcUMHMn25oV2ej7cZhk+CTqLYTc?= =?us-ascii?Q?mBWmzfaZosEn+b/QGIwmXDdVHYHCjYTgCJFLXxVchHDolXkSChD5taHp5iko?= =?us-ascii?Q?wr0ABZ3pev2DWcpICoR43jV9HUgi2T7DPGHgKRhadCSnfBF3Rga1IP6eEHod?= =?us-ascii?Q?5Uv9H5RKX2HuVAGtuzrUeX2nf7VwtZqFp4deIUgR8XgMfSKK9mYb+O9v1fs3?= =?us-ascii?Q?bbPh1UZisvk6jVUpC8vkewRqFnUHjHEWxNKSRfuvbIQV8zHnQFZ2GmoG564S?= =?us-ascii?Q?NOjZO1gUmELla/HnT884MlHB7Zv3IhSWgsoRTs8YaTp/C2rJSLmRnWdMJDi3?= =?us-ascii?Q?SY+1y5RbOkckRQdsn8XDExc5E3onuhDJUkvUUqkIkRyAtXqQBm357ULrDoDx?= =?us-ascii?Q?2Wej0NHt3EH0rrMGB4Fe4HZoxqx51EaIQriq7i877n8Zhl2ExRRI0UhrWsrH?= =?us-ascii?Q?yTlU5QV0pRz7zh/VK42fVpQQ/NlkSxqKDC9RqDJ24EYPoyboO5CC8qvyarL6?= =?us-ascii?Q?dfT0K4LpCl8iwx4Ppo0c2fJ/XE/dI4jTrgB63XbiXYixjrQPXgbOw32MPOI4?= =?us-ascii?Q?XTSa9E/l+WfdqWyhgwA0YID/usiLBSHf2XiemJOiqGztna37P44sOvDqhvzw?= =?us-ascii?Q?tXpHR2X537BDhO4jVeWzNHkez/N0dYIRqEGsaFNbnCWsV0A1RMwzrdZIRt4/?= =?us-ascii?Q?8QptnnaxE67Xbw3RgqTC8MEviGoLL0De4XP+0SEb9b7zbtgO7EhUIjH5Z50j?= =?us-ascii?Q?rdxJmbCSH90hvbmy0cPoadyhgec8Eg864ILHS4x6gx2lk4bnnAflHwRKuA01?= =?us-ascii?Q?D/z+HOw1UqxVY+lE75NN6pn+YSGMb6iZdFEUI1pU6jIDPT+EoU4kPjO95/zL?= =?us-ascii?Q?QWYkLTOz+EW8gF1S/rXma85MWkRA+x5UcF3iSr4U/bXAOck3fvZQnwriea4r?= =?us-ascii?Q?GJOaApKYso9rmO95Dk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0036;6:RpJ7iLneoxb9dgU+BliiwhAgi9ozOTSirdqUhS2F0Ok7HcIvX2T6XfCclJGn2pDyY55pzcpx4qS/5t6VpZhciMKztnMNEFwSRXsxT1M+yWrUAfwK4JbjUUp/czSL0EQ+JMfQc3Z9QtJuv+GB7Rw5AVHdjQbKcuDTJc5c6i6scCi7wrTNx+6KfZ+bTSJI+Pfa7jSbZS5gsX7zhJLOr7TJLFaamU/iZ1HBXYhIwhoDZRr73rO24s1UkVFd2SvbmoEdl2JI+VbZ5Jz5Un6fzqeoOV/hdsiVhQo8WFBc8fg4vUuyzOupiEVMR5gvKYXRRpFBhKve30tBt2X34AJaBmwmkg==;5:NUOv34ukyuVL8jAcPm/Ff2yMV/6DOUT5Z5NMxGOkfTzA370ILeGcanX5xBZ6MKOy7IuH1pEmeqwqxY6MkGDfCARLTtBMrz/SYEtSCkFbmwDB6Xw8+edIIeiySq2opR5gUMvK9PlUkD57j5jaA6WRZQ==;24:HBhVVHWuyEOZlKr7Z02FXPGYmaTUBJuwcZy7rLG8NR+MatAkQW4y3+642m3WMvGoeiqg1GVOvXJZptIpwXvqv5/XNeKx6FHm6R8ndl2mGhQ=;7:iqcsc+rQF199oU/Po3ncBmiRu8xg2PyHDXffr+0eWxKRL7XGYectyxV3idKamVVFhFTsTutrqX7RmqPdYmFSpwASHn3zwvrDzBcOD18q8KI4NbjcnAG8jhVmww3S6dkR8IADhsngT9kBjykNnB24YgLIj9foTlddJTfYrxj2m+N2PTlpC3zLKu9c9xlCeb2VFcEdFgIrunnDBnC5vJxDc7A8HDAb33QO3QrUxHVPTyxlVa6S0Nqzl7lrCoXTtTWy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0036;20:N1BuFeW1m0Hy9K7WOtfmmE+xeMzh8u7kyypRROpoPoomPUQuwKLVt4se4sEuiBtgHvcxGVGsr9OzBUfEt9j7JzI/lWn/i+uVFPxdqv6ofeu+8y8g89iW35a90XIUjiNi+bVbveRlrBpM6f7tJ5T3HPMQr1PIhb++zJDtdCLauwxqoM/GCxLF+MZTKPZP9MkR0Xm2g5y8wipDFMjHm39lgvxrseGshA2wwJOg5i9r7cFxt6wAW4hZPap53SiLCx4u X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2016 09:10:14.0124 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.22];Helo=[SATLEXCHOV02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR12MB0036 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 03, 2016 at 01:57:14PM +0800, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for 'cz_send_msg_to_smc_async' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype for 'cz_write_smc_sram_dword' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/iceland_smc.c:124:6: warning: no previous prototype for 'iceland_start_smc' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3926:6: warning: no previous prototype for 'gfx_v8_0_rlc_stop' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:94:6: warning: no previous prototype for 'amdgpu_job_free_cb' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Thanks. Acked-by: Huang Rui