linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Moshe Green <mgmoshes@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-fbdev@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	teddy.wang@siliconmotion.com
Subject: Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c
Date: Sat, 3 Sep 2016 22:57:50 +0300	[thread overview]
Message-ID: <20160903195750.GA6323@gmail.com> (raw)
In-Reply-To: <20160902113508.GA18456@kroah.com>

On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote:
> > There were (mostly) two kinds of warnings that I've handled, "80
> > character line length" and block comments structure.
> > Some of the changes involve handling two separate warnings in a single comment.
> > Where this occurs, should I break down the change into two steps -
> > fixing a warning at a time?
> > Or should I fix both warnings in the same commit - and place the
> > commit in the most appropriate patch?
> 
> Hm, use your best judgement here, what would you want to be on the
> receiving end of if you had to review such a patch series?
> 
> thanks,
> 
> greg k-h

Will do.

thanks,

Moshe Green

      reply	other threads:[~2016-09-03 19:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 19:04 [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c Moshe Green
2016-08-30 19:04 ` [PATCH 2/9] " Moshe Green
2016-08-30 19:04 ` [PATCH 3/9] staging: sm750fb: fix coding style issues " Moshe Green
2016-08-30 19:04 ` [PATCH 4/9] " Moshe Green
2016-08-30 19:05 ` [PATCH 5/9] " Moshe Green
2016-08-30 19:05 ` [PATCH 6/9] staging: sm750fb: fix line length coding style issue " Moshe Green
2016-08-30 19:05 ` [PATCH 7/9] staging: sm750fb: fix block comment style issues " Moshe Green
2016-08-30 19:19   ` Joe Perches
2016-08-30 19:42     ` moshe green
2016-08-30 19:05 ` [PATCH 8/9] staging: sm750fb: fix line length coding style issue " Moshe Green
2016-08-30 19:06 ` [PATCH 9/9] " Moshe Green
2016-09-01 16:04 ` [PATCH 1/9] " Greg KH
2016-09-02  8:28   ` moshe green
2016-09-02 11:35     ` Greg KH
2016-09-03 19:57       ` Moshe Green [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160903195750.GA6323@gmail.com \
    --to=mgmoshes@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).