public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Chen Gang <chengang@emindsoft.com.cn>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"minchan@kernel.org" <minchan@kernel.org>,
	"vbabka@suse.cz" <vbabka@suse.cz>,
	"gi-oh.kim@profitbricks.com" <gi-oh.kim@profitbricks.com>,
	"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
	"hillf.zj@alibaba-inc.com" <hillf.zj@alibaba-inc.com>,
	"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"rientjes@google.com" <rientjes@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"hskinnemoen@gmail.com" <hskinnemoen@gmail.com>,
	"egtvedt@samfundet.no" <egtvedt@samfundet.no>,
	"realmz6@gmail.com" <realmz6@gmail.com>,
	"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
	"rkuo@codeaurora.org" <rkuo@codeaurora.org>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"james.hogan@imgtec.com" <james.hogan@imgtec.com>,
	"ralf@linux-mips.org" <ralf@linux-mips.org>,
	"dhowells@redhat.com" <dhowells@redhat.com>,
	"deller@gmx.de" <deller@gmx.de>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	"paulus@samba.org" <paulus@samba.org>,
	"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"dalias@libc.org" <dalias@libc.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions)
Date: Sun, 4 Sep 2016 02:01:44 +0100	[thread overview]
Message-ID: <20160904010144.GD2356@ZenIV.linux.org.uk> (raw)
In-Reply-To: <57CB5088.6050007@emindsoft.com.cn>

On Sun, Sep 04, 2016 at 06:36:56AM +0800, Chen Gang wrote:

> And for all: shall I provide the proof for another archs?
> 
> For me, Boolean gives additional chance to compiler to improve the code.

Whereas for compiler it gives nothing.  Not in those cases.

> If the compiler can not improve the code, it can treat it as int simply.
> So theoretically, at least, Boolean should not be worse than int.

Except for pointless code churn and pandering to irrational beliefs, that is...
Please, RTFISO9899 and learn the semantics of _Bool; it's not that complicated.
Start with 6.2.5[2,6] and 6.3.1.2, then look through 6.8.4 and 6.8.5 to
figure out the semantics of conditions in if/while/for.  Note also 6.5.8,
6.5.9, 6.5.13 and 6.5.14 and observe that type of (x > 5 && y < 1) is *NOT* 
_Bool; it's int.

If you can show any improvement or loss in code generation in this case
(static inline int converted to static inline bool), I would really like to
see the details.  As in .config/file/function/gcc version/target architecture.
Optimizer bugs happens, but they should be reported when found, and I would
expect _Bool handling to be _less_ exercised than that of normal logical
expressions, so loss is probably more likely.  And yes, it also should be
reported.

  reply	other threads:[~2016-09-04  5:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-28  5:39 [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions chengang
2016-08-28  7:02 ` kbuild test robot
2016-08-28  7:10 ` kbuild test robot
2016-08-28  7:10 ` kbuild test robot
2016-08-28 14:54   ` Chen Gang
2016-08-29  8:45 ` Michal Hocko
2016-08-29 13:03 ` Arnd Bergmann
2016-08-29 13:46   ` Peter Zijlstra
2016-08-29 13:54     ` Geert Uytterhoeven
2016-08-29 16:48   ` Vineet Gupta
2016-08-29 21:49     ` Chen Gang
2016-09-01 20:43       ` cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions) Al Viro
2016-09-02 23:33         ` Chen Gang
2016-09-03  0:07           ` Vineet Gupta
2016-09-03 22:36             ` Chen Gang
2016-09-04  1:01               ` Al Viro [this message]
2016-09-07 15:58                 ` Chen Gang
2016-09-11 12:27                 ` Chen Gang
2016-08-29 22:01   ` [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160904010144.GD2356@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=chengang@emindsoft.com.cn \
    --cc=dalias@libc.org \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=dhowells@redhat.com \
    --cc=egtvedt@samfundet.no \
    --cc=fenghua.yu@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=gi-oh.kim@profitbricks.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=hskinnemoen@gmail.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=james.hogan@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mattst88@gmail.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=realmz6@gmail.com \
    --cc=rientjes@google.com \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=tony.luck@intel.com \
    --cc=vbabka@suse.cz \
    --cc=will.deacon@arm.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox