public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolai Stange <nicstange@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org,
	Nicolai Stange <nicstange@gmail.com>
Subject: [RFC v5 08/23] arch/s390/kernel/time: set ->min_delta_ticks and ->max_delta_ticks
Date: Sun,  4 Sep 2016 03:01:45 +0200	[thread overview]
Message-ID: <20160904010200.17200-9-nicstange@gmail.com> (raw)
In-Reply-To: <20160904010200.17200-1-nicstange@gmail.com>

With the yet to come introduction of NTP correction awareness to the
clockevent core, drivers should report their valid ranges in units of
cycles to the latter.

Currently, the s390's CPU timer clockevent device is initialized as
follows:

  cd->min_delta_ns    = 1;
  cd->max_delta_ns    = LONG_MAX;

Note that the device's time to cycle conversion factor, i.e.
cd->mult / (2^cd->shift), is approx. equal to 4.

Hence, this would translate to

  cd->min_delta_ticks = 4;
  cd->max_delta_ticks = 4 * LONG_MAX;

However, a minimum value of 1ns is in the range of noise anyway and the
clockevent core will take care of this by increasing it to 1us or so.
Furthermore, 4*LONG_MAX will overflow the unsigned long argument the
clockevent devices gets programmed with.

Thus, initialize ->min_delta_ticks with 1 and ->max_delta_ticks with
ULONG_MAX.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
 arch/s390/kernel/time.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/s390/kernel/time.c b/arch/s390/kernel/time.c
index 4e99498..9e66df1 100644
--- a/arch/s390/kernel/time.c
+++ b/arch/s390/kernel/time.c
@@ -166,7 +166,9 @@ void init_cpu_timer(void)
 	cd->mult		= 16777;
 	cd->shift		= 12;
 	cd->min_delta_ns	= 1;
+	cd->min_delta_ticks	= 1;
 	cd->max_delta_ns	= LONG_MAX;
+	cd->max_delta_ticks	= ULONG_MAX;
 	cd->rating		= 400;
 	cd->cpumask		= cpumask_of(cpu);
 	cd->set_next_event	= s390_next_event;
-- 
2.9.3

  parent reply	other threads:[~2016-09-04  1:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04  1:01 [RFC v5 00/23] adapt clockevents frequencies to mono clock Nicolai Stange
2016-09-04  1:01 ` [RFC v5 01/23] clocksource: sh_cmt: compute rate before registration again Nicolai Stange
2016-09-04  1:01 ` [RFC v5 02/23] clocksource: sh_tmu: " Nicolai Stange
2016-09-04  1:01 ` [RFC v5 03/23] clocksource: em_sti: split clock prepare and enable steps Nicolai Stange
2016-09-04  1:01 ` [RFC v5 04/23] clocksource: em_sti: compute rate before registration Nicolai Stange
2016-09-04  1:01 ` [RFC v5 05/23] clocksource: h8300_timer8: don't reset rate in ->set_state_oneshot() Nicolai Stange
2016-09-04  1:01 ` [RFC v5 06/23] clockevents: make clockevents_config() static Nicolai Stange
2016-09-04  1:01 ` [RFC v5 07/23] many clockevent drivers: set ->min_delta_ticks and ->max_delta_ticks Nicolai Stange
2016-09-04  1:01 ` Nicolai Stange [this message]
2016-09-04  1:01 ` [RFC v5 09/23] arch/x86/platform/uv/uv_time: " Nicolai Stange
2016-09-04  1:01 ` [RFC v5 10/23] arch/tile/kernel/time: " Nicolai Stange
2016-09-04  1:01 ` [RFC v5 11/23] clockevents: always initialize ->min_delta_ns and ->max_delta_ns Nicolai Stange
2016-09-04  1:28 ` [RFC v5 12/23] many clockevent drivers: don't set " Nicolai Stange
2016-09-04  1:28 ` [RFC v5 13/23] clockevents: introduce CLOCK_EVT_FEAT_NO_ADJUST flag Nicolai Stange
2016-09-04  1:28 ` [RFC v5 14/23] clockevents: decouple ->max_delta_ns from ->max_delta_ticks Nicolai Stange
2016-09-04  1:28 ` [RFC v5 15/23] clockevents: do comparison of delta against minimum in terms of cycles Nicolai Stange
2016-09-04  1:28 ` [RFC v5 16/23] clockevents: clockevents_program_min_delta(): don't set ->next_event Nicolai Stange
2016-09-04  1:28 ` [RFC v5 17/23] clockevents: use ->min_delta_ticks_adjusted to program minimum delta Nicolai Stange
2016-09-04  1:28 ` [RFC v5 18/23] clockevents: min delta increment: calculate min_delta_ns from ticks Nicolai Stange
2016-09-04  1:28 ` [RFC v5 19/23] timer_list: print_tickdevice(): calculate ->min_delta_ns dynamically Nicolai Stange
2016-09-04  1:28 ` [RFC v5 20/23] clockevents: purge ->min_delta_ns Nicolai Stange
2016-09-04  1:28 ` [RFC v5 21/23] clockevents: initial support for mono to raw time conversion Nicolai Stange
2016-09-04  9:50   ` Nicolai Stange
2016-09-04  1:28 ` [RFC v5 22/23] clockevents: make setting of ->mult and ->mult_adjusted atomic Nicolai Stange
2016-09-04  1:28 ` [RFC v5 23/23] timekeeping: inform clockevents about freq adjustments Nicolai Stange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160904010200.17200-9-nicstange@gmail.com \
    --to=nicstange@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox