From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753895AbcIDIfe (ORCPT <rfc822;w@1wt.eu>);
        Sun, 4 Sep 2016 04:35:34 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:54176 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753760AbcIDIfc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 4 Sep 2016 04:35:32 -0400
Date: Sun, 4 Sep 2016 10:35:37 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Amit Ghadge <amitg.b14@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
Message-ID: <20160904083537.GA18355@kroah.com>
References: <1472933463-5290-1-git-send-email-amitg.b14@gmail.com>
 <1472933463-5290-2-git-send-email-amitg.b14@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1472933463-5290-2-git-send-email-amitg.b14@gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
> Fixes checkpatch warning:
> WARNING: Block comments use * on subsequent lines
> 
> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
> of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
> Replace Avoid CamelCase range_0_20mA to range_0_20ma.

That's multiple things in the same patch, and you didn't even test build
your change :(

Please do better than this in the future.

greg k-h