From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Louie Lu <louie.lu@hopebaytech.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
florian.c.schilhabel@googlemail.com, punitvara@gmail.com,
bhaktipriya96@gmail.com, linux-kernel@vger.kernel.org,
laerdevstudios@gmail.com, shivanib134@gmail.com,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8712: fixed comment style and space indent
Date: Sun, 4 Sep 2016 21:02:40 +0530 [thread overview]
Message-ID: <20160904153240.GC29779@sudip-laptop> (raw)
In-Reply-To: <20160902131415.GA17715@gserv>
On Fri, Sep 02, 2016 at 09:14:15PM +0800, Louie Lu wrote:
> fixed comment style and space indent report from checkpatch
> in rtl8712/rtl871x_ioctl_linux.c:
>
> * WARNING: Statements should start on a tabstop
> * WARNING: Block comments use * on subsequent lines
> * WARNING: suspect code indent for conditional statements (16, 32)
>
> Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
> ---
That becomes 3 different changes in a single patch.
You should be doing a single type of change in a patch.
please break them into separate patches.
regards
sudip
prev parent reply other threads:[~2016-09-04 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 13:14 [PATCH] staging: rtl8712: fixed comment style and space indent Louie Lu
2016-09-04 15:32 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160904153240.GC29779@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bhaktipriya96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=laerdevstudios@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louie.lu@hopebaytech.com \
--cc=punitvara@gmail.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox