From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754092AbcIDP3r (ORCPT <rfc822;w@1wt.eu>);
        Sun, 4 Sep 2016 11:29:47 -0400
Received: from mga07.intel.com ([134.134.136.100]:18073 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751539AbcIDP3n (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 4 Sep 2016 11:29:43 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,281,1470726000"; 
   d="scan'208";a="757064651"
Date: Sun, 4 Sep 2016 23:37:39 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, x86@kernel.org,
        John Stultz <john.stultz@linaro.org>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        Xunlei Pang <xlpang@redhat.com>, "3.17+" <stable@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org
Subject: Re: [PATCH][RFC v5] timekeeping: Ignore the bogus sleep time if
 pm_trace is enabled
Message-ID: <20160904153739.GA5400@sharon>
References: <1472402439-1146-1-git-send-email-yu.c.chen@intel.com>
 <4130556.MNmyvLDyHH@vostro.rjw.lan>
 <alpine.DEB.2.20.1609022119160.5647@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1609022119160.5647@nanos>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thomas, Rafael,
On Fri, Sep 02, 2016 at 09:26:51PM +0200, Thomas Gleixner wrote:
> On Wed, 31 Aug 2016, Rafael J. Wysocki wrote:
> > On Monday, August 29, 2016 12:40:39 AM Chen Yu wrote:
> > > +
> > > +	/*
> > > +	 * Make rtc-based persistent clock unusable
> > > +	 * if pm_trace is enabled, only take effect
> > > +	 * for timekeeping_suspend/resume.
> > > +	 */
> > > +	if (pm_trace_is_enabled() &&
> > > +	    x86_platform.get_wallclock == mach_get_cmos_time) {
> > > +		ts->tv_sec = 0;
> > > +		ts->tv_nsec = 0;
> > > +	}
> > 
> > I'm not sure about this.  Looks hackish.
> 
> Indeed. Can't you just keep track that pm_trace fiddled with the cmos clock
> and then discard the value either in the core or in mach_get_cmos_time()
The previous version is more straightforward, since
it ignored the bogus rtc in core. Would you please take
a glance at it too, thanks:
https://patchwork.kernel.org/patch/9287347/

Thanks,
Yu