From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbcIDOMj (ORCPT ); Sun, 4 Sep 2016 10:12:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42966 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbcIDOMi (ORCPT ); Sun, 4 Sep 2016 10:12:38 -0400 Date: Sun, 4 Sep 2016 16:12:33 +0200 From: Jiri Benc To: Haishuang Yan Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vxlan: Update tx_errors statistics if vxlan_build_skb return err. Message-ID: <20160904161233.063d0009@griffin> In-Reply-To: <1472986371-75583-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1472986371-75583-1-git-send-email-yanhaishuang@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sun, 04 Sep 2016 14:12:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 4 Sep 2016 18:52:51 +0800, Haishuang Yan wrote: > If vxlan_build_skb return err < 0, tx_errors should be also increased. > > Signed-off-by: Haishuang Yan > --- > drivers/net/vxlan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c > index f605a36..2c72dcd 100644 > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2103,6 +2103,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, > vni, md, flags, udp_sum); > if (err < 0) { > dst_release(ndst); > + dev->stats.tx_errors++; > return; > } > udp_tunnel6_xmit_skb(ndst, sk, skb, dev, Acked-by: Jiri Benc The error path in vxlan_xmit_one deserves complete rework, though. Jiri