From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754465AbcIDUPU (ORCPT ); Sun, 4 Sep 2016 16:15:20 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:41361 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754405AbcIDUPT (ORCPT ); Sun, 4 Sep 2016 16:15:19 -0400 Date: Sun, 4 Sep 2016 14:14:06 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: move struct tpm_class_ops to drivers/char/tpm/tpm.h Message-ID: <20160904201406.GA9854@obsidianresearch.com> References: <1472852886-7640-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160902221122.GA1897@obsidianresearch.com> <20160902223522.GA27454@intel.com> <20160902224531.GC1897@obsidianresearch.com> <20160903062221.GA2061@intel.com> <20160903062605.GB2061@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160903062605.GB2061@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 03, 2016 at 09:26:05AM +0300, Jarkko Sakkinen wrote: > > > > OK, how would one get the chip instance? Most subsystems have a get function that returns a kref'd pointer. For TPM all we really need today is a 'get_default_tpm_for_ns' kind of function. > This still doesn't explain why moving the structures inside the driver > would be wrong. Even if outside callers would use a pointer the > structure could be opaque. For instance, if we did a get function then the 'put' function would be an inline around dev_put and that needs to see inside the chip. This is a well trodden pattern in the kernel, there is no reason to do something different for tpm. Jason