* [PATCH] s390/cpum_cf: Use kmalloc_array() in merge_attr()
@ 2016-09-03 13:27 SF Markus Elfring
2016-09-05 11:34 ` Hendrik Brueckner
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2016-09-03 13:27 UTC (permalink / raw)
To: linux-s390, Heiko Carstens, Hendrik Brückner,
Martin Schwidefsky
Cc: LKML, kernel-janitors, Julia Lawall, Paolo Bonzini
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 3 Sep 2016 15:17:45 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus reuse the corresponding function "kmalloc_array".
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kernel/perf_cpum_cf_events.c b/arch/s390/kernel/perf_cpum_cf_events.c
index 4554a4b..0d6340b 100644
--- a/arch/s390/kernel/perf_cpum_cf_events.c
+++ b/arch/s390/kernel/perf_cpum_cf_events.c
@@ -274,7 +274,7 @@ static __init struct attribute **merge_attr(struct attribute **a,
j++;
j++;
- new = kmalloc(sizeof(struct attribute *) * j, GFP_KERNEL);
+ new = kmalloc_array(j, sizeof(*new), GFP_KERNEL);
if (!new)
return NULL;
j = 0;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/cpum_cf: Use kmalloc_array() in merge_attr()
2016-09-03 13:27 [PATCH] s390/cpum_cf: Use kmalloc_array() in merge_attr() SF Markus Elfring
@ 2016-09-05 11:34 ` Hendrik Brueckner
0 siblings, 0 replies; 2+ messages in thread
From: Hendrik Brueckner @ 2016-09-05 11:34 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-s390, Heiko Carstens, Hendrik Brückner,
Martin Schwidefsky, LKML, kernel-janitors, Julia Lawall,
Paolo Bonzini
On Sat, Sep 03, 2016 at 03:27:42PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 3 Sep 2016 15:17:45 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus reuse the corresponding function "kmalloc_array".
>
> * Replace the specification of a data type by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/perf_cpum_cf_events.c b/arch/s390/kernel/perf_cpum_cf_events.c
> index 4554a4b..0d6340b 100644
> --- a/arch/s390/kernel/perf_cpum_cf_events.c
> +++ b/arch/s390/kernel/perf_cpum_cf_events.c
> @@ -274,7 +274,7 @@ static __init struct attribute **merge_attr(struct attribute **a,
> j++;
> j++;
>
> - new = kmalloc(sizeof(struct attribute *) * j, GFP_KERNEL);
> + new = kmalloc_array(j, sizeof(*new), GFP_KERNEL);
> if (!new)
> return NULL;
> j = 0;
> --
Looks good to me. Thanks.
Acked-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-05 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-03 13:27 [PATCH] s390/cpum_cf: Use kmalloc_array() in merge_attr() SF Markus Elfring
2016-09-05 11:34 ` Hendrik Brueckner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox