From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935119AbcIERmT (ORCPT ); Mon, 5 Sep 2016 13:42:19 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51404 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933787AbcIERmO (ORCPT ); Mon, 5 Sep 2016 13:42:14 -0400 Date: Mon, 5 Sep 2016 19:42:11 +0200 From: Boris Brezillon To: Artem Bityutskiy , Richard Weinberger Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] UBI: use vol->usable_leb_size instead of (ubi->leb_size - vol->data_pad) Message-ID: <20160905194211.705d5162@bbrezillon> In-Reply-To: <1473089487-29285-4-git-send-email-boris.brezillon@free-electrons.com> References: <1473089487-29285-1-git-send-email-boris.brezillon@free-electrons.com> <1473089487-29285-4-git-send-email-boris.brezillon@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Sep 2016 17:31:24 +0200 Boris Brezillon wrote: > vol->usable_size is already set to ubi->leb_size - vol->data_pad. Use > vol->usable_size instead of recalculating it. This one should be part of the cleanup series. > > Signed-off-by: Boris Brezillon > --- > drivers/mtd/ubi/cdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c > index 72ba84af6698..45c329694a5e 100644 > --- a/drivers/mtd/ubi/cdev.c > +++ b/drivers/mtd/ubi/cdev.c > @@ -416,7 +416,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd, > } > > rsvd_bytes = (long long)vol->reserved_pebs * > - ubi->leb_size-vol->data_pad; > + vol->usable_leb_size; > if (bytes < 0 || bytes > rsvd_bytes) { > err = -EINVAL; > break;