From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755497AbcIEUVr (ORCPT ); Mon, 5 Sep 2016 16:21:47 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54946 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754488AbcIEUVq (ORCPT ); Mon, 5 Sep 2016 16:21:46 -0400 Date: Mon, 5 Sep 2016 22:21:43 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Thomas Petazzoni Subject: Re: [PATCH 5/7] ARM: sun8i: a33: Add display pipeline Message-ID: <20160905202143.GC8596@lukather> References: <20160901153204.11217-1-maxime.ripard@free-electrons.com> <20160901153204.11217-6-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uh9ZiVrAOUUm9fzH" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uh9ZiVrAOUUm9fzH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Sep 02, 2016 at 02:28:54PM +0800, Chen-Yu Tsai wrote: > > + be0: display-backend@01e60000 { > > + compatible =3D "allwinner,sun8i-a33-display-bac= kend"; > > + reg =3D <0x01e60000 0x10000>; >=20 > Please also list the interrupt, even though we don't use it yet. > The manual says it's 127 - 32 =3D 95. Yep, you're right. > > + sat0: sat@01e80000 { > > + compatible =3D "allwinner,sun8i-a33-sat"; > > + reg =3D <0x01e80000 0x1000>; > > + clocks =3D <&ccu CLK_BUS_SAT>; > > + resets =3D <&ccu RST_BUS_SAT>; > > + > > + ports { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + sat0_in: port@0 { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + reg =3D <0>; > > + > > + sat0_in_fe0: endpoint@0 { > > + reg =3D <0>; > > + remote-endpoint =3D <&f= e0_out_sat0>; > > + }; > > + }; > > + > > + sat0_out: port@1 { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + reg =3D <1>; > > + > > + sat0_out_be0: endpoint@0 { > > + reg =3D <0>; > > + remote-endpoint =3D <&b= e0_in_sat0>; > > + }; > > + }; >=20 > I'm worried about the representation here. >=20 > In the user manuals, the SAT is shown as part of the BE. Look at it > this way: if it did come before the BE and is independent, we > shouldn't have to bring the SAT out of reset for simplefb to work. Indeed. > For comparison, a similar function unit called "CMU" found on the > other post-sun6i SoCs has the same function description as SAT on > the A33. It uses the reserved registers at the beginning of the BE > address space. Hmm, ok, so you would essentially, merge the backend and sat nodes? That wouldn't be very hard to do, i'll do it. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --uh9ZiVrAOUUm9fzH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXzdPXAAoJEBx+YmzsjxAgjloP/2AjzS1liw6Sf1L/cUyoLr/m i2rfMDlH9XsFwgos0yEXYqpd1XC0D2NZKcjW9AU0WJAHi53n7QIXPQI0cEOnvQAc EP25I4rwaClLuWeurar1W1MexB3/F0O/yZq103A9Pp1XVxkkrUtZROWxM0Y5BMhw 4BywlU6TJ9Vt/Y2gakBKveEBUwJ1mf+xpyMgKnu/3I10yyl85yK/83u1KhUaDJnF 6MB4Prhi2gtjR0TiZgzFL9uuyY62ZUvXk3H3Ha0FKQPkYeAcD+dP9hhoxKEA/hFE DOXgPr4xs1soBvdqc+WnFM2kvrLkeKHiw3wq8R+nigL7JXElblt17RtEJMxUbstu WOERfLL7tcCCDwH0UGO4lkbLTehzN4bbgm7c/tCfVGjch4vY8FZWCdbiHUD1mowB FA8dOf0eH3Li+QZGVBuSLWi0Lm4oD5QPcNl7CHpVTkMOMZrMPMB1ILJtiwrxvIDd mu8g4FoUD7OguQovyRkkvThrv4kQGK2qKA1vuceAhOc7xWd13fsEkDvhZ8j2yeGK fgXZ9SM4yxOuxkPx5zTPLn+xG59Gk9RoSXdMlpFKZoqgJSr12PMdf3Kgoc9LdPeF ogBb/35P8c4qSY4T4+Aa8Xjlmk+t2gYFc4wSnm5+9O7MMLja3qr95qjeWz8xv/Gl D5GmwcUpu6DTNe2lyVcZ =q0kd -----END PGP SIGNATURE----- --uh9ZiVrAOUUm9fzH--