From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934085AbcIFUUD (ORCPT ); Tue, 6 Sep 2016 16:20:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59240 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933598AbcIFUUC (ORCPT ); Tue, 6 Sep 2016 16:20:02 -0400 Date: Tue, 6 Sep 2016 13:20:01 -0700 From: Andrew Morton To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm: cleanup pfn_t usage in track_pfn_insert() Message-Id: <20160906132001.cd465767fa9844ddeb630cc4@linux-foundation.org> In-Reply-To: <147318058712.30325.12749411762275637099.stgit@dwillia2-desk3.amr.corp.intel.com> References: <147318056046.30325.5100892122988191500.stgit@dwillia2-desk3.amr.corp.intel.com> <147318058712.30325.12749411762275637099.stgit@dwillia2-desk3.amr.corp.intel.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Sep 2016 09:49:47 -0700 Dan Williams wrote: > Now that track_pfn_insert() is no longer used in the DAX path, it no > longer needs to comprehend pfn_t values. What's the benefit in this? A pfn *should* have type pfn_t, shouldn't it? Confused.