From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755932AbcIFOZV (ORCPT ); Tue, 6 Sep 2016 10:25:21 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:45249 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbcIFOZS (ORCPT ); Tue, 6 Sep 2016 10:25:18 -0400 Date: Tue, 6 Sep 2016 15:24:42 +0100 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Eric Miao , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mmp: replace NO_IRQ Message-ID: <20160906142442.GY1041@n2100.armlinux.org.uk> References: <20160906140808.2883875-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160906140808.2883875-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote: > The mmp platform has its own definitions with the old NO_IRQ meaning, > but compares against the global NO_IRQ macro that we should have > removed long ago. > > The specific usage in arch/arm/mach-mmp/devices.c is awkward, but > fixing it properly would require a larger scale rewrite of the entire > file, or even using devicetree for all machines. As I'm not able to > do that any time soon, let's make the current behavior more explit > instead and avoid the literal use of NO_IRQ. So this probably continues to be a problem, but we hide it from the NO_IRQ brigade. I think it would be better to leave it as-is until it can be fixed up correctly, rather than trying to hide it. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.