Re: [PATCH] ARM: mmp: replace NO_IRQ

Linus Torvalds
2016-09-06T20:03:45Z

On Tue, Sep 6, 2016 at 12:44 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
>
> My point still stands though. Merely hiding it doesn't make the problem
> go away - it's just the same problem but now it won't be as visible, and
> as such it'll probably never get resolved.

How much of a legacy thing is this?

The main reason I'd like to _really_ make NO_IRQ go away is that it
seems that some people copy it from existing drivers, or just think
it's the RightThing(tm) to do because it looks so plausible.

So in that sense I wouldn't actually mind "merely hiding it".

It may not *fix* that particular driver or subsystem, but if it's
sufficiently well hidden or specialized, at least it won't cause the
pattern to be copied in the future, I'd hope.

So hiding things inside a particular driver (or a particular
subsystem) may be hacky from the standpoint of that particular driver
or subsystem, but from a "big issue" standpoint I don't mind at all.

Linus