From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756037AbcIFNv3 (ORCPT ); Tue, 6 Sep 2016 09:51:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:53352 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755063AbcIFNv1 (ORCPT ); Tue, 6 Sep 2016 09:51:27 -0400 Date: Tue, 6 Sep 2016 15:50:30 +0200 From: Boris Brezillon To: Arnd Bergmann Cc: Baoyou Xie , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, Thierry Reding Subject: Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static Message-ID: <20160906155030.01501417@bbrezillon> In-Reply-To: <5193604.cj3c1WipcO@wuerfel> References: <1473147976-25092-1-git-send-email-baoyou.xie@linaro.org> <5193604.cj3c1WipcO@wuerfel> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Sep 2016 15:43:45 +0200 Arnd Bergmann wrote: > On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > So this patch marks it 'static'. > > > > Signed-off-by: Baoyou Xie > > > > Acked-by: Arnd Bergmann Actually, Thierry already posted the same patch a while ago. I just sent a PR to Dave containing this patch.