From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753090AbcIHAli (ORCPT ); Wed, 7 Sep 2016 20:41:38 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:50510 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcIHAlb (ORCPT ); Wed, 7 Sep 2016 20:41:31 -0400 Date: Wed, 07 Sep 2016 17:41:30 -0700 (PDT) Message-Id: <20160907.174130.1794006266279661720.davem@davemloft.net> To: baoyou.xie@linaro.org Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH] qed: add missing header dependencies From: David Miller In-Reply-To: <1473246420-1035-1-git-send-email-baoyou.xie@linaro.org> References: <1473246420-1035-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 07 Sep 2016 17:41:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baoyou Xie Date: Wed, 7 Sep 2016 19:07:00 +0800 > We get 4 warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_selftest.c:6:5: warning: no previous prototype for 'qed_selftest_memory' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_selftest.c:19:5: warning: no previous prototype for 'qed_selftest_interrupt' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_selftest.c:32:5: warning: no previous prototype for 'qed_selftest_register' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_selftest.c:55:5: warning: no previous prototype for 'qed_selftest_clock' [-Wmissing-prototypes] > > In fact, these functions are declared in qed_selftest.h, so this patch > add missing header dependencies. > > Signed-off-by: Baoyou Xie Applied.