From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755989AbcIGAdE (ORCPT ); Tue, 6 Sep 2016 20:33:04 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39632 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbcIGAdB (ORCPT ); Tue, 6 Sep 2016 20:33:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 0205961567 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 6 Sep 2016 17:32:58 -0700 From: Stephen Boyd To: Masahiro Yamada Cc: Greg Kroah-Hartman , Michael Turquette , Linux Kernel Mailing List , linux-clk , Geert Uytterhoeven , linux-arm-kernel , Andrew Morton , "David S. Miller" , Guenter Roeck Subject: Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver Message-ID: <20160907003258.GP12510@codeaurora.org> References: <1470112223-24835-1-git-send-email-yamada.masahiro@socionext.com> <1470112223-24835-2-git-send-email-yamada.masahiro@socionext.com> <20160819002507.GS361@codeaurora.org> <20160819191612.GU361@codeaurora.org> <20160829182200.GD19826@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05, Masahiro Yamada wrote: > 2016-08-30 3:22 GMT+09:00 Stephen Boyd : > > On 08/29, Masahiro Yamada wrote: > >> I tried this, but it did not work. > >> > >> To make dev_get_regmap() work, > >> the parent device needs to call dev_regmap_init_mmio() beforehand. > >> > >> > >> Since commit bdb0066df96e74a4002125467ebe459feff1ebef > >> (mfd: syscon: Decouple syscon interface from platform devices), > >> syscon_probe() is not called for platform devices, > >> so that never happens. > >> > > > > Ok. Is the syscon also a simple-mfd? > > > > It sounds like there's a device for the parent, but we've failed > > to attach a regmap to it. Maybe the core DT code should assign > > the regmap to the parent device when it creates it so that child > > devices don't need to know this detail? It could look for > > simple-mfd devices with compatible = "syscon" and then create the > > regmap? Here's a totally untested patch for that. > > > > > I was not quire sure about this, > but maybe worth submitting to DT subsystem? > > Anyway, I will go with syscon_node_to_regmap() for v7. > Of course, I am happy to replace it with dev_get_regmap() > when the issue is solved in the mainline. > Ok that's fine. Did my patch fix dev_get_regmap() for you though? That would be useful to know so that this patch can be merged in parallel to yours. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project