Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Arnd Bergmann
2016-09-08T12:15:08Z

On Thursday, September 8, 2016 3:02:56 PM CEST Grygorii Strashko wrote:
> dwc3: probe()
> if (!&pdev->dev->of_node)
> legacy case - hard-code DMA props
> dwc->sysdev = &pdev->dev;

The PCI case will fall into this too, as we almost never have an
->of_node pointer for a PCI device.

Do we actually have any legacy dwc3 users in Linux that are neither DT
nor PCI based? Maybe we can just skip that.

> else
> dev = &pdev->dev;
> do {
> if (is_device_dma_capable(dev)) {
> dwc->sysdev = dev;
> break;
> }
> dev = dev->parent;
> while (dev);
> ^this cycle can be limited in depth (2 for PCI)

Right, this could work by itself and looks generic enough.

Arnd